From owner-svn-ports-head@freebsd.org Thu Dec 7 12:27:00 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14364E856CC; Thu, 7 Dec 2017 12:27:00 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (gahr.cloud.tilaa.com [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0DBC933C2; Thu, 7 Dec 2017 12:26:58 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id e4dcc691 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 7 Dec 2017 12:26:57 +0000 (UTC) Date: Thu, 7 Dec 2017 12:26:57 +0000 From: Pietro Cerutti To: Mathieu Arnold Cc: Joe Marcus Clarke , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207122656.k2t2uruhqwrhzt3f@ptrcrt.ch> Reply-To: Pietro Cerutti References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> <20171207120403.7wafl635xclviqsr@ptrcrt.ch> <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z6uhslesy46g6wvv" Content-Disposition: inline In-Reply-To: <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org> X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20171027-245-1d0c7d X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 12:27:00 -0000 --z6uhslesy46g6wvv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 13:07, Mathieu Arnold wrote: > Le 07/12/2017 =C3=A0 13:04, Pietro Cerutti a =C3=A9crit=C2=A0: > > On Dec 7 17 06:22, Joe Marcus Clarke wrote: > >> On 12/7/17 03:13, Pietro Cerutti wrote: > >>> On Dec 7 17 08:10, Pietro Cerutti wrote: > >>>> On Dec 7 17 08:04, Pietro Cerutti wrote: > >>>>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: > >>>>>> Author: marcus > >>>>>> Date: Tue Aug 15 12:43:14 2017 > >>>>>> New Revision: 447981 > >>>>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 > >>>>>> > >>>>>> Log: > >>>>>> Update to 2.17.12. > >>>>>> @@ -3400,6 +3437,11 @@ sub abspathname { > >>>>>> =20 > >>>>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > >>>>>> # MASTER_SITE_SUBDIR lines are ok. > >>>>>> + $i =3D ''; > >>>>>> + } > >>>>>> + if ($s =3D~ /\$\{[^}]*?$i/) { > >>>>>> + # If we're inside a make variable, we probably do not have > >>>>>> + # an absolute path. > >>>>>> $i =3D ''; > >>>>>> } > >>>>>> } > >>>>>> > >>>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2= >&1 )=20 > >>>>> <-- HERE / at /usr/local/bin/portlint line 3443. > >>>>> > >>>>> I think the ? doesn't belong there. > >>>> No, my analysis was wrong. It's about the contents of the $i variabl= e.=20 > >>>> Here's why. You can reproduce by portlint -AC in net-im/openfire. > >>>> > >>>> i is /var/log/openfire > >>>> WARN: Makefile: possible use of absolute pathname "/var/log/openfire= ". > >>>> > >>>> i is /var/db/openfire > >>>> WARN: Makefile: possible use of absolute pathname "/var/db/openfire". > >>>> > >>>> i is /dev/null 2>&1 ) > >>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>= &1 )=20 > >>>> <-- HERE / at /usr/local/bin/portlint line 3444. > >>> Surrounding $i with \Q and \E in the regex solves the problem. > >>> > >>> > >> Thanks. I'll commit a quick fix ahead of the next release. > > Thanks. I still don't understand why you have both * and ? as=20 > > quantifiers, though. >=20 >=20 > perlre(1): >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *?=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Match 0 or more times, not greedily >=20 oh, the non-greedy qualifier, thanks! --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --z6uhslesy46g6wvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlopM4wuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntkXEADICUd6FtyKKjBZKO16IX72kdCQ1stM4HIAtWimnSuw3D0twMm0KmhaiMfq gKQMOkdDq1vSIDvdXSRPHAe7nLzzEhUsUYUJDqoJdy5NIEwDkm/CnVolemV4ml6W nqrfjNcYiTszDMkQZBxJmZe5nr3QGYb+MlsjCHvgKiWLG0TUGUSmOLbVRrERyML9 ziyNml8RVUotggL6ZfKZ5/YUo0rv2evkoYNAJJ7fUA4ajI9Dpe5c+IX5mLjBGs+0 ZdN1ftqk/QEoYglnUQXW1ah3sD59KO6d9hLxmxU55rCqQYwbvTh9w/F5xU75tOxq 6JuGZ14D9HkEnnaF5LE7FYextkkD0fkedeE60schxtVMRPuUwzAC6gHlKM8+0z1r 2s2AS8NxkvAAEx8rQXDC+SBCOigI+GT7Ac5C/ZqiapKTv4x/mgCAWYJ/9ra4iXQG yPunEYuqw8fSB5eDUtepp50Fbkx7+tCrH2PmF1buAaL+t7unw3liQZAewrHCgJXL lS5CwcHbaoAg+4ncylbHxpYRLquLIMHR989APhy+qmt7zciAcny088m5bkNc4CZf ikMr/j6At3OmS7CEIMaSCHy5tt7ti64N2as8yD8vzTSREHe3H4j3R1worAJIwhPb myG0Rtl/w8FloyYYPKDvfO9F375rHZQQ05oEpElyh/zwozSCZA== =YBbG -----END PGP SIGNATURE----- --z6uhslesy46g6wvv--