From owner-freebsd-embedded@FreeBSD.ORG Wed Nov 13 22:32:45 2013 Return-Path: Delivered-To: freebsd-embedded@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3ECAB4C6; Wed, 13 Nov 2013 22:32:45 +0000 (UTC) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 05C2525C9; Wed, 13 Nov 2013 22:32:45 +0000 (UTC) Received: from adrastea.jupiter.sigsegv.be (unknown [IPv6:2a02:1811:2000:701:1b:9fff:fe00:160b]) by venus.codepro.be (Postfix) with ESMTPSA id B1CF39B29; Wed, 13 Nov 2013 23:32:43 +0100 (CET) Received: from sigsegv.be (unknown [10.0.2.251]) by adrastea.jupiter.sigsegv.be (Postfix) with ESMTP id BA2B1415F; Wed, 13 Nov 2013 23:32:42 +0100 (CET) From: kristof@sigsegv.be To: Ian Lepore Subject: [PATCH 1/5] Fix typo in struct onfi_params Date: Wed, 13 Nov 2013 23:32:36 +0100 Message-Id: <1384381960-98851-2-git-send-email-kristof@sigsegv.be> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1384381960-98851-1-git-send-email-kristof@sigsegv.be> References: <1383782353.31172.183.camel@revolution.hippie.lan> <1384381960-98851-1-git-send-email-kristof@sigsegv.be> Cc: Grzegorz Bernacki , freebsd-embedded@FreeBSD.org X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2013 22:32:45 -0000 From: Kristof Provost The vendor specified field is 88 bytes, not 8 bytes. See ONFI specification rev. 2.3a: 5.7.1 Parameter Page Data Structure Definition --- sys/dev/nand/nand.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/nand/nand.h b/sys/dev/nand/nand.h index d2aa661..1ca0fb2 100644 --- a/sys/dev/nand/nand.h +++ b/sys/dev/nand/nand.h @@ -31,6 +31,7 @@ #include #include +#include #include #include #include @@ -218,9 +219,10 @@ struct onfi_params { uint8_t driver_strength_support; uint8_t res4[12]; uint16_t vendor_rev; - uint8_t vendor_spec[8]; + uint8_t vendor_spec[88]; uint16_t crc; }__attribute__((packed)); +CTASSERT(sizeof(struct onfi_params) == 256); struct nand_ecc_data { int eccsize; /* Number of data bytes per ECC step */ -- 1.7.10.3