Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Oct 2018 05:40:52 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        Cy Schubert <Cy.Schubert@cschubert.com>, Jochen Neumeister <joneum@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r482290 - head/lang/lua52
Message-ID:  <201810171240.w9HCeqhS040190@slippy.cwsent.com>
In-Reply-To: Message from Jan Beich <jbeich@FreeBSD.org> of "Wed, 17 Oct 2018 14:21:04 %2B0200." <4ldk-69xr-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <4ldk-69xr-wny@FreeBSD.org>, Jan Beich writes:
> Cy Schubert <Cy.Schubert@cschubert.com> writes:
>
> > In message <201810170939.w9H9dh0b028473@repo.freebsd.org>, Jochen 
> > Neumeister wr
> > ites:
> >
> >> Author: joneum
> >> Date: Wed Oct 17 09:39:42 2018
> >> New Revision: 482290
> >> URL: https://svnweb.freebsd.org/changeset/ports/482290
> >>
> >> Log:
> >>   Pass maintainership to submitter
> >>   
> >>   PR:		232320
> >>   Submitted by:	John Von Essen <john@essenz.com>
> >>   Sponsored by:	Netzkommune GmbH
> >>
> >> Modified:
> >>   head/lang/lua52/Makefile
> >>
> >> Modified: head/lang/lua52/Makefile
> >> ==========================================================================
> ===
> >> =
> >> --- head/lang/lua52/Makefile	Wed Oct 17 09:30:08 2018	(r48228
> 9)
> >> +++ head/lang/lua52/Makefile	Wed Oct 17 09:39:42 2018	(r48229
> 0)
> >> @@ -7,7 +7,7 @@ CATEGORIES=	lang
> >>  MASTER_SITES=	http://www.lua.org/ftp/
> >>  PKGNAMESUFFIX=	52
> >>  
> >> -MAINTAINER=	ports@FreeBSD.org
> >> +MAINTAINER=	john@essenz.com
> >>  COMMENT=	Small, compilable scripting language providing easy access to C
> >>  code
> >>  
> >>  LICENSE=	MIT
> >>
> >
> > It used to be that maintainership of a port would be passed to the 
> > submitter after or while accepting a patch or patches to a port. Has 
> > this policy changed?
>
> Where is such a policy documented? Otherwise, "as soon as you wish"
> hasn't changed for more than 10 years.
>
> https://svnweb.freebsd.org/changeset/doc/26046
> https://www.freebsd.org/doc/en/articles/contributing/ports-contributing.html#
> idp55292232

I recall mat@ commenting on this a couple of times over the years. Must 
be one of those unwritten things. I recall mat@ weighing in on this a 
couple of times before.

Anyhow, there are too many times I have had to obtain maintainer 
approval from a maintainer who hasn't submitted any other patches or 
done any other work on a port, only to wait for a maintainer approval 
that never arrives. Therefore check for commits where the maintainer 
has submitted patches and check for PRs. If the last commit was handing 
over maintainer approval and the maintainer has done nothing since, 
simply commit without maintainer approval then.

I can't recall how many times I've come across this issue.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810171240.w9HCeqhS040190>