From nobody Tue Oct 10 01:58:45 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4JwQ1qkhz4wthP for ; Tue, 10 Oct 2023 01:58:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S4JwQ0mkYz4Mqx for ; Tue, 10 Oct 2023 01:58:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696903126; a=rsa-sha256; cv=none; b=uVpW4STZMid6p2wVevYqdSaOsQI5+s0occK/8fLJr3sLwXfzCyXNBa9PVEHrwxlBasqf7J 2ctGs5JIkIraMsHj+mdKQDLHImy+b52df3Q1czL927fAg695ozyx74vY+NDTTefidThnfH y224//EXbwdWf04mJDbpQQw0GBMcWEe0c6fu+6kalOOuohrrEcYUkCPn+t1rD6KLvigTjE m43BUzv+D2xmdgfEqC51e9zmJDKYXrSveP2h9kySawrWPaNey/BuUjEwCR55LwnOGKpDVp 41vt09mV55Yec2uQQZC/jszLCv0ouOT8Rr8dY2L513ecPE+z2FfIbe6KomD4ZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696903126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yFDXsfQKEAIm5RT2nmqp4cT/ei6euAt72WIE1cOBTjc=; b=owTMH0jA7veaaEt95OajwqxVZ54jp+q3Tcwgs5zZnc4Xen5rxENx0iDuLNvemijdDtVgg8 /yvX90Amd3XOY+rTIlHIC22AocxFErpz7mUWyF1mCEpaRtoKLLIJnA2xz4xDwmefqtGWnv WsqU4N7anG/rCx9Dg+gIoh9l47Lez5jOZtrHB7oca/x8LAg5gvAhEm2I4YVs4WamZjythv vpBgxUoyvyeZrL8+K/PsBN7IKw9d8TVGEup5i77WLoXs9p0VOVGuLeYWrZXvE2jvJF9oiG NCx81+xWgBrvZv+YbnLgkWZnKfi1KDFLAEPIZpS03vzYqL2HCt8uWT6L698xRA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S4JwP6yrdz4Jh for ; Tue, 10 Oct 2023 01:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39A1wjK1062096 for ; Tue, 10 Oct 2023 01:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39A1wjTe062095 for bugs@FreeBSD.org; Tue, 10 Oct 2023 01:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271750] setusercontext(): Apply user '.login_conf' on process' effective uid being set Date: Tue, 10 Oct 2023 01:58:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271750 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D892654fe9b5a9115815c30a423b8db471= 85aebbd commit 892654fe9b5a9115815c30a423b8db47185aebbd Author: Olivier Certner AuthorDate: 2023-05-30 16:35:08 +0000 Commit: Ed Maste CommitDate: 2023-10-10 01:47:10 +0000 setusercontext(): Apply personal settings only on matching effective UID Commit 35305a8dc114 (r211393) added a check on whether 'uid' was equal to getuid() before calling setlogincontext(). Doing so still allows a setuid program to apply resource limits and priorities specified in a user-controlled configuration file ('~/.login_conf') where a non-setuid program could not. Plug the hole by checking instead that the process' effective UID is the target one (which is likely what was meant in the initial commit). PR: 271750 Reviewed by: kib, des MFC after: 2 weeks Sponsored by: Kumacom SAS Differential Revision: https://reviews.freebsd.org/D40351 lib/libutil/login_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=