From owner-freebsd-arch@FreeBSD.ORG  Thu May 31 00:36:47 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1400316A41F
	for <freebsd-arch@freebsd.org>; Thu, 31 May 2007 00:36:47 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outU.internet-mail-service.net (outU.internet-mail-service.net
	[216.240.47.244])
	by mx1.freebsd.org (Postfix) with ESMTP id F1D9D13C4C3
	for <freebsd-arch@freebsd.org>; Thu, 31 May 2007 00:36:46 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Wed, 30 May 2007 17:36:46 -0700
Received: from julian-mac.elischer.org (nat.ironport.com [63.251.108.100])
	by idiom.com (Postfix) with ESMTP id 2C0E9125B4A;
	Wed, 30 May 2007 17:36:46 -0700 (PDT)
Message-ID: <465E189C.4000609@elischer.org>
Date: Wed, 30 May 2007 17:36:44 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326)
MIME-Version: 1.0
To: Bruce Evans <brde@optusnet.com.au>
References: <20070529105856.L661@10.0.0.1>
	<200705291456.38515.jhb@freebsd.org>	<20070529121653.P661@10.0.0.1>
	<20070530065423.H93410@delplex.bde.org>	<20070529141342.D661@10.0.0.1>
	<20070530125553.G12128@besplex.bde.org>	<20070529201255.X661@10.0.0.1>
	<20070529220936.W661@10.0.0.1>	<20070530201618.T13220@besplex.bde.org>
	<20070530115752.F661@10.0.0.1>
	<20070531091419.S826@besplex.bde.org>
In-Reply-To: <20070531091419.S826@besplex.bde.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-arch@freebsd.org
Subject: Re: Updated rusage patch
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2007 00:36:47 -0000

Bruce Evans wrote:

> - RELENG_4: statclock() uses splhigh() but not interrupt atomicity.
>             exit1() uses no locking and thus races with statclock().
>   above: statclock() still uses sched_lock but not interrupt atomicity.


sched_lock blocks interrupts

>          exit1() uses no locking and thus races with statclock().

> Time fields are mostly in rux and still fully locked by sched_lock.
> exit1() copies some of them to p_ru, but that copy is not used.  I
> think proc locking is still used for p_ru -- it is used in kern_wait(),
> where it seems to be necessary to prevent multiple threads in the
> parent process racing to reap the child.
> 
> Bruce
> _______________________________________________
> freebsd-arch@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"