From owner-svn-src-stable@freebsd.org Tue May 21 16:54:17 2019 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 475D715B2676; Tue, 21 May 2019 16:54:17 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C81A06E438; Tue, 21 May 2019 16:54:16 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x4LGsEDv080016; Tue, 21 May 2019 09:54:14 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x4LGsEAR080015; Tue, 21 May 2019 09:54:14 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905211654.x4LGsEAR080015@gndrsh.dnsmgr.net> Subject: Re: svn commit: r348012 - in stable/12: libexec/rc sbin/ifconfig share/man/man5 tools/tools/tinybsd/conf/firewall/etc usr.sbin/jail In-Reply-To: <20190521164033.GG68351@spindle.one-eyed-alien.net> To: Brooks Davis Date: Tue, 21 May 2019 09:54:14 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C81A06E438 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0] X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2019 16:54:17 -0000 > On Mon, May 20, 2019 at 06:30:26PM -0700, Rodney W. Grimes wrote: > > > Author: brooks > > > Date: Mon May 20 21:33:22 2019 > > > New Revision: 348012 > > > URL: https://svnweb.freebsd.org/changeset/base/348012 > > > > > > Log: > > > MFC r347963: > > > > > > Change ed(4), ep(4), and fxp(4) examples to em(4). > > > > > > ed(4) and ep(4) will be removed in FreeBSD 13. fxp(4) remains > > > popular in older systems, but isn't as future proof as em(4). > > > > > > Reviewed by: bz, jhb > > > Differential Revision: https://reviews.freebsd.org/D20311 > > > > Though this made since to me in head, it does not in stable, > > as you may of just broke someones running system when they > > do a merge master if they happened to of depended on the very > > long standing defaults of fxp that are NOT in comment lines > > below. > > I didn't really thing about fact these are actual defaults. We should > comment out or remove most/all of these out. They are a terrible idea... > > I've reverted in r348055. Thank you, and I fully agree on the terrible idea, perhaps look at rewritting the effected code so that it errors out or at least warns if these values are not set, then remove the setting of them in etc/default/rc.conf would be one way to clean this up. > -- Brooks -- Rod Grimes rgrimes@freebsd.org