From owner-svn-src-head@FreeBSD.ORG Sat Jun 20 15:15:12 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 460A9105; Sat, 20 Jun 2015 15:15:12 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 028C5890; Sat, 20 Jun 2015 15:15:11 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::40f9:e9b6:a14d:99c3] (unknown [IPv6:2001:7b8:3a7:0:40f9:e9b6:a14d:99c3]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 8228D264DD; Sat, 20 Jun 2015 17:15:03 +0200 (CEST) Subject: Re: svn commit: r284644 - head/usr.sbin/fstyp Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_20283D61-8B2E-4A5B-A995-D7F30BFE20A3"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5 From: Dimitry Andric In-Reply-To: <5585820C.4000209@freebsd.org> Date: Sat, 20 Jun 2015 17:14:54 +0200 Cc: Benjamin Kaduk , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: References: <201506201503.t5KF33Km091795@svn.freebsd.org> <5585820C.4000209@freebsd.org> To: Allan Jude X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 15:15:12 -0000 --Apple-Mail=_20283D61-8B2E-4A5B-A995-D7F30BFE20A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 20 Jun 2015, at 17:09, Allan Jude wrote: >=20 > On 2015-06-20 11:05, Benjamin Kaduk wrote: ... >> Are the warnings emitted by gcc posted somewhere so that I can = convince >> myself dropping WARNS is better than changing the code to work around = them? >>=20 >> -Ben >=20 > The warnings come from the ZFS contrib code, so I was under the > impression we didn't want to fix those and diverge form upstream. >=20 > via kib on irc: >=20 > =3D=3D=3D> usr.sbin/fstyp (all) > cc1: warnings being treated as errors > In file included from > /scratch/tmp/kib/src/usr.sbin/fstyp/../../sys/cddl/contrib > from /scratch/tmp/kib/src/usr.sbin/fstyp/zfs.c:41: > n/fs/zfs/sys/dmu.h:638: warning: function declaration isn't a = prototype > n/fs/zfs/sys/dmu.h:639: warning: function declaration isn't a = prototype Those functions are declared like this, without any parameters, as if they were K&R functions: void xuio_stat_wbuf_copied(); void xuio_stat_wbuf_nocopy(); and also their definitions lack any parameters: void xuio_stat_wbuf_copied() { XUIOSTAT_BUMP(xuiostat_wbuf_copied); } void xuio_stat_wbuf_nocopy() { XUIOSTAT_BUMP(xuiostat_wbuf_nocopy); } Obviously, these should just have (void) as their parameter list. For such a trivial change, it should be no problem to modify it locally, and then notify upstream. -Dimitry --Apple-Mail=_20283D61-8B2E-4A5B-A995-D7F30BFE20A3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlWFg3cACgkQsF6jCi4glqPrUACeOl26oJdE/H7n820Bjkckmq+r heEAn1L60F7mnFJ7Pb37bwwoLoCxOXWs =RUIB -----END PGP SIGNATURE----- --Apple-Mail=_20283D61-8B2E-4A5B-A995-D7F30BFE20A3--