Date: Tue, 24 Apr 2018 09:46:42 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Yuri Victorovich <yuri@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468186 - head/databases/sfcgal Message-ID: <20180424074642.lttispipfbvrg7xy@atuin.in.mat.cc> In-Reply-To: <201804240728.w3O7SaRa036534@repo.freebsd.org> References: <201804240728.w3O7SaRa036534@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mktrzbrwqb6xfaxx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Apr 24, 2018 at 07:28:36AM +0000, Yuri Victorovich wrote:
> +
> +PLIST_SUB=3D SHL3=3D${PORTVERSION} SHL1=3D${PORTVERSION:R:R}
While your SHL3 replacements are something that is somewhat ok, though
unnecessary with make makeplist, the SHL1 is a very bad idea.
Because when the major version changes, it will get automagically
changed in the plist, and the maintainer will not think about bumping
all dependent ports.
Whereas if the plist needs updating, it shows the major shlib version
update, and it is harder to miss.
> lib/libSFCGAL.so
> -lib/libSFCGAL.so.1
> -lib/libSFCGAL.so.1.3.2
> +lib/libSFCGAL.so.%%SHL1%%
> +lib/libSFCGAL.so.%%SHL3%%
--=20
Mathieu Arnold
--mktrzbrwqb6xfaxx
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAABCgBmBQJa3uDiXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IhccQAJjdyA/FwqBtsje9yfzeXKUC
mZQH70ArjY+mi9iWfB4e7C5vLpiust3lhYazenEG5eYe6dk80ZCONTrHC4oun6S5
6ESKn8Jj6PaEM7MpemvHX6zsluFvjKKTba6NpLmzQZUxZpnvgt86bK1ULrz5wSeU
tBTJ8hqVovspLYbwXLKmaVFgzkE/fAuuDHnFKRxpE4enFiiQ45dwuOsdHUCvvKs7
FgipKkO93ZiK4+T6fuC41G/9mJt16w9H37h2hnU4TR4aYTv6HoO0rGjwQYkceCy+
/f2+qXfplVG5OL/RY6uh8cB5jxqm7FhLtb2WwvGl4kad/k3YVppqnf7NmMflBlcD
SOX9/J37rbNt7pl1v/a6dsZSZ6S8/SzDoPxp0h4jLg8LQwsqiwLw3HZlgK1KY1WI
z+HpmkRTOkMe+TREAEdfxtNPYqzLDYm+s+2OSFqlMayuxccD909oNeQWLrBmIsDj
5XSmVH9R2UMsvo7SMSauX0aS6LxZ+VOJoNuHxzE67JiwSuVAIZcOzDM8qS2W1gLN
jfmqHJOpO90rnDlJ+zJ9JmHWgBHZeDl8w8P3av69pF4wq6ZexKPuTAn+DlUVHQMS
iQeYYJ83gb2npW0mzUoepdbZzDI0mY+K/tObO6joCqAvN0rw7HKcO+/ZErYXPP/S
VRTvNV6d4ZMu3E3F4kPt
=dvvr
-----END PGP SIGNATURE-----
--mktrzbrwqb6xfaxx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180424074642.lttispipfbvrg7xy>