Date: Wed, 17 Jan 2018 19:40:01 +0100 From: =?utf-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> To: Freddie Cash <fjwcash@gmail.com> Cc: Adam Weinberger <adamw@adamw.org>, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: Help with versioning scheme Message-ID: <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de> In-Reply-To: <CAOjFWZ7xMcSQWRYAfaSA%2Baxm9de9bdsikqRZJfZXbsEb8%2B_oSg@mail.gmail.com> References: <F35F7011-4DDA-4BD4-93FB-BE75ECD49827@waschbuesch.de> <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org> <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de> <CAOjFWZ7xMcSQWRYAfaSA%2Baxm9de9bdsikqRZJfZXbsEb8%2B_oSg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks, Freddie,
> Am 17.01.2018 um 19:35 schrieb Freddie Cash <fjwcash@gmail.com>:
>=20
> On Wed, Jan 17, 2018 at 10:29 AM, Martin Waschb=C3=BCsch =
<martin@waschbuesch.de <mailto:martin@waschbuesch.de>> wrote:
> Hi Adam,
> > Am 17.01.2018 um 19:19 schrieb Adam Weinberger <adamw@adamw.org =
<mailto:adamw@adamw.org>>:
> > Hi Martin,
> >
> > You don't want to use the upstream version to represent =
PORTREVISION. PORTREVISION is for when you need to force rebuilds of the =
port itself, and so tying it to upstream would make it impossible to =
bump it ourselves.
> >
> > Why do you need to ignore the fourth digit? It's perfectly valid for =
our purposes.
>=20
> So far, I had (because it coincided with their version number) used it =
to provide SO_VER. But that breaks now:
>=20
> ---
> # Created by: adamw
> # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z =
sunpoet $
>=20
> PORTNAME=3D lz4
> PORTVERSION=3D 1.8.1
> DISTVERSIONPREFIX=3D v
> PORTEPOCH=3D 1
> CATEGORIES=3D archivers
> PKGNAMEPREFIX=3D lib
>=20
> MAINTAINER=3D martin@waschbuesch.de <mailto:martin@waschbuesch.de>
> COMMENT=3D LZ4 compression library, lossless and very fast
>=20
> LICENSE=3D BSD2CLAUSE GPLv2
> LICENSE_COMB=3D multi
>=20
> USES=3D gmake pathfix pkgconfig
> USE_GITHUB=3D yes
> USE_LDCONFIG=3D yes
> #PATHFIX_MAKEFILEIN=3D Makefile
>=20
> ALL_TARGET=3D default # don't remove this
> SO_VER=3D ${PORTVERSION}
> PLIST_SUB+=3D SO_VER=3D${SO_VER} SO_VER_MAJ=3D${SO_VER:R:R}
>=20
> =E2=80=8BWhy can't you do something like the above to get SO_VER?
>=20
> PORTVERSION=3D1.8.1.2
> SO_VER=3D${PORTVERSION:R:R:R)
>=20
> Similar to how you get SO_VER_MAJ out of SO_VER.=E2=80=8B
That is true. Do you think this is a robust solution, though?
Or is the whole relying on upstream variables idea problematic?=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32>