From owner-dev-commits-src-main@freebsd.org Sat Mar 6 12:44:15 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0030556667F for ; Sat, 6 Mar 2021 12:44:15 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dt46k6cyJz3s0q; Sat, 6 Mar 2021 12:44:14 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (unknown [IPv6:2601:405:4a00:acd:505:9a8d:4e89:d6f5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: nwhitehorn/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id B8D6423A9B; Sat, 6 Mar 2021 12:44:14 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Subject: Re: git: e77cf2a4ab32 - main - Restore /boot/efi to mtree. To: Mark Millard , dev-commits-src-main@freebsd.org References: <656E3D05-11B6-437B-B171-4894811A70CB@yahoo.com> From: Nathan Whitehorn Message-ID: Date: Sat, 6 Mar 2021 07:44:13 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 12:44:15 -0000 On 3/6/21 4:43 AM, Mark Millard wrote: > On 2021-Mar-6, at 01:01, Mark Millard wrote: > >> On 2021-Mar-5, at 22:05, Mark Millard wrote: >>> Nathan Whitehorn nwhitehorn at FreeBSD.org wrote on >>> Sat Mar 6 02:01:30 UTC 2021 : >>> >>>> Restore /boot/efi to mtree. >>>> >>>> Instead of whether /boot/efi exists, which it now always does, including >>>> on systems that don't and can't use EFI, use whether /boot/efi is >>>> present in fstab to signal to the installer that it is a valid ESP and >>>> should be configured. This has essentially the same semantics, but allows >>>> /boot/efi to be created unconditionally. >>>> >>> Sounds like the documentation about /etc/fstab content >>> should indicate the special/reserved /boot/efi usage >>> context, be that comments in initial default files or >>> whatever. >>> >>> I wonder if anyone puts / at the end in an fstab: /boot/efi/ >>> >> I tried using a trailing / in /etc/fstab and it is >> one place were the notational variation is not >> equivalent: I had to remove it. >> > FYI: > > Reviewing/adjusting my /etc/fstab files I notice that > I have examples with things like: > > /dev/label/Rock64boot /boot/efi msdosfs rw,noatime,noauto 0 0 > > #/dev/msdosfs/RPI4EFIFS /boot/efi msdosfs rw,noatime,noauto 0 0 > > Some might have a space after the #, shifting the > /boot/efi to be at $3 ? Some /etc/fstab files have both > types of /boot/efi lines (commented vs. uncommented), > associated with root-file-system-media that I move > between machines sometimes and toggle what is commented > (changing what media ends up referenced). > This change *only* applies to boot partitions created by the installer, which have a well-known (to the installer) and controlled format. As you note, though, there are a variety of ways someone could write this in their fstab, which makes this approach tricky for updating, and is why I originally preferred the simpler method of seeing whether the mountpoint existed. -Nathan