From owner-svn-src-all@FreeBSD.ORG Fri Nov 16 16:02:40 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C6B2D172; Fri, 16 Nov 2012 16:02:40 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-da0-f54.google.com (mail-da0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 83A258FC14; Fri, 16 Nov 2012 16:02:39 +0000 (UTC) Received: by mail-da0-f54.google.com with SMTP id z9so1288847dad.13 for ; Fri, 16 Nov 2012 08:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=qVjNt7bSyK2A3WGwmOvd+revgsmE23PViBIvsHsvgkw=; b=kmKitn+1siCZNFYUv/mUm7DMX79dJy8sKtMC6iyJK03HoFmQyrjSONNKX0Ft50Plio 200ZV5h/pbi35NozDxH9NGGHMDEwhrKYPLDX1FDtGUozPAzoPNmvuNrT0TuJpeIYd1ih HEbrMgvhTuDPWdfG0O7+XWZ9nVKwtIpkgN/vdWrvKSB08axECrM2MyVlwE2MfI7tW9wv HJbB1wY0WU1MAJYVBYI6qp058RZ2l5gi32duSgZ2fn2jbE2uyvJ9iBQOvL5OyWurxOcR 77zv/z3h3ifLBXKYisOECoDNtorYkdtmKT0TzQ8UsQH19171PIhtDgrcbIxk1DyH7o0K F0pQ== MIME-Version: 1.0 Received: by 10.68.245.169 with SMTP id xp9mr16336498pbc.142.1353081759266; Fri, 16 Nov 2012 08:02:39 -0800 (PST) Sender: mdf356@gmail.com Received: by 10.68.132.136 with HTTP; Fri, 16 Nov 2012 08:02:39 -0800 (PST) In-Reply-To: <201211160625.qAG6PLd2032062@svn.freebsd.org> References: <201211160625.qAG6PLd2032062@svn.freebsd.org> Date: Fri, 16 Nov 2012 08:02:39 -0800 X-Google-Sender-Auth: 1u2PnjJ2Q_92JY5TqyU4dmIxoeI Message-ID: Subject: Re: svn commit: r243134 - head/sys/sys From: mdf@FreeBSD.org To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 16:02:40 -0000 On Thu, Nov 15, 2012 at 10:25 PM, Konstantin Belousov wrote: > Author: kib > Date: Fri Nov 16 06:25:20 2012 > New Revision: 243134 > URL: http://svnweb.freebsd.org/changeset/base/243134 > > Log: > Alphabetically reorder the forward-declarations of the structures. > Add the declaration for enum idtype, to be used later. Forward declarations of enums isn't an ISO C feature, but a gcc extension. While the kernel uses many gcc extensions, it hides most under a #define so unsupported compilers can continue along. This unsupported feature can't be hidden. Does the forward declaration prevent another warning? Thanks, matthew > Reported and reviewed by: bde > MFC after: 28 days > > Modified: > head/sys/sys/syscallsubr.h > > Modified: head/sys/sys/syscallsubr.h > ============================================================================== > --- head/sys/sys/syscallsubr.h Fri Nov 16 06:22:14 2012 (r243133) > +++ head/sys/sys/syscallsubr.h Fri Nov 16 06:25:20 2012 (r243134) > @@ -35,25 +35,26 @@ > #include > > struct file; > +enum idtype; > struct itimerval; > struct image_args; > struct jail; > +struct kevent; > +struct kevent_copyops; > +struct kld_file_stat; > +struct ksiginfo; > struct mbuf; > struct msghdr; > struct msqid_ds; > +struct ogetdirentries_args; > struct rlimit; > struct rusage; > -struct __wrusage; > union semun; > +struct sendfile_args; > struct sockaddr; > struct stat; > -struct kevent; > -struct kevent_copyops; > -struct kld_file_stat; > -struct ksiginfo; > -struct sendfile_args; > struct thr_param; > -struct ogetdirentries_args; > +struct __wrusage; > > int kern___getcwd(struct thread *td, u_char *buf, enum uio_seg bufseg, > u_int buflen);