From owner-freebsd-current Sat Feb 1 16:14:36 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 868BA37B405 for ; Sat, 1 Feb 2003 16:14:35 -0800 (PST) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 253F843FA7 for ; Sat, 1 Feb 2003 16:14:34 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.6/8.12.6) with ESMTP id h120ESSJ018046; Sat, 1 Feb 2003 16:14:28 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.6/8.12.6/Submit) id h120ESxb018045; Sat, 1 Feb 2003 16:14:28 -0800 (PST) Date: Sat, 1 Feb 2003 16:14:28 -0800 (PST) From: Matthew Dillon Message-Id: <200302020014.h120ESxb018045@apollo.backplane.com> To: Mark Murray Cc: current@FreeBSD.ORG Subject: Re: Style fixups for proc.h References: <200302012345.h11NjqaX028714@grimreaper.grondar.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :WARNS=5. This isn't helpful. I tried adding every -W switch in bsd.sys.mk and couldn't reproduce the problem. What compiler option is causing the problem? :> :2 ways to fix this are to "protect" the prototype argument names with the :> :"_", or to remove the argument name altogether. :> :> If it is a problem, why not simply use the same variable names that are :> declared in the procedure proper? The underscore looks ugly and out of :> place and doesn't make that much sense to me. : :Because this doesn't always help, or if it did, the diffs are often :much bigger and to many more files. : :M :-- :Mark Murray :iumop ap!sdn w,I idlaH Ok, now I'm really confused. How can it not always help? If the arguments are the same as the arguments declared in the underlying procedures why would an error still be produced? The diff you produced for proc.h is *already* fairly extensive. If you want to fix this, you only need to fix the lines generating compiler warnings. I really dislike screwing around with source code to work around bugs in the the compiler, or lint. Given the choice of underlines or leaving the arguments unnamed, I would leave them unnamed. Or I would figure out and remove whatever broken compiler option is generating the warning in the first place. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message