From owner-freebsd-emulation@freebsd.org Sat May 9 21:18:04 2020 Return-Path: Delivered-To: freebsd-emulation@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9150A2F6372 for ; Sat, 9 May 2020 21:18:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49KKmX2LVDz4Lmc for ; Sat, 9 May 2020 21:18:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 5074F2F6371; Sat, 9 May 2020 21:18:04 +0000 (UTC) Delivered-To: emulation@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 503CE2F6370 for ; Sat, 9 May 2020 21:18:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49KKmX05pNz4Lmb for ; Sat, 9 May 2020 21:18:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by freefall.freebsd.org (Postfix) id CFB87EC23; Sat, 9 May 2020 21:18:03 +0000 (UTC) Delivered-To: vbox@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id B11E8E9FF for ; Sat, 9 May 2020 21:18:03 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49KKmV0zmYz4LmZ; Sat, 9 May 2020 21:18:01 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x42c.google.com with SMTP id i15so6077798wrx.10; Sat, 09 May 2020 14:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NozMTRC55zz0lX5Qh7AgzijEmyhxRBZhU0AaijnKsXg=; b=NvbGMtpGNuYmtKqcbwJh0ao5cWZPHCDhhCZ7UT7NPn9YlRv19r8aG4DY8kBOW9C0KF OOhdsrT66WVE+xSsO+LUZ+MSVolv9Zk9sH+QzNCnA4Eo5GJufeVfe4nIeGJhEs5iVy3X 3P80i6o2WRv10qD3X1PERSOxxGXXGbLB1q6hPE9JNJbpgEkSH90N5+5pU/nnMHnsOJmH 8Qk30qnnasWni19JgjWunedXSxal562J+h73GVwNFkA5W3SxUb+RT4HKSlqAAHanDviS QTgZB9x13eHZKOnlCjNY2xdRsTcnDvl/bMcVLFYfv46WYaczoJSXFmotlVLOtgiG69FL CiEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NozMTRC55zz0lX5Qh7AgzijEmyhxRBZhU0AaijnKsXg=; b=Vz1Qhnn81edpeqGNvob9Ah+85d9jRuYkKy1YJ5uzrOsq9emDEc8XMnKp1w7+AruB0d r39btAoVoHfUol9TeEYIQr4YZPBs/fYwj1DIsARbRjQCmcsm0wRu7kl4auQYcCBHwHEg zJiq331Sm3cMD+/CsEAFMS/7lJi/1N0n/qHRyxF6iq21AVxtWp4po1KXpNspxOpvfRCD V7LN3F0U19e1G7mlWlkkBSP3UHggeqJundOTGil4HSTiQqAvynJBZ/CxksaMKR6Mgdmi nEUQx38YBiYUfyUvIp0Q/lkvJpEXjxi0+RcFtrAOGA5Tyz0pi0oUl5/CpHTFPT2qpryv 3X8A== X-Gm-Message-State: AGi0PuYGqMHorqgmr5ORPEFKP/fWPILNdAO4xtaUdYT/xGuQFUJV3ZKX VxjTeSAcu4G4PruVBDSiqaelq8TbaJtb9d757xG3QjlR X-Google-Smtp-Source: APiQypK8jCMWBZm1A+S3scJGjDH520rTmugfbhfVS/pRdszu0/Wdb6Ygb2k71SiYN9aEyJzYtRSbPd5oecqq/3/0DfY= X-Received: by 2002:adf:cd92:: with SMTP id q18mr10401194wrj.237.1589059080487; Sat, 09 May 2020 14:18:00 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:a55a:0:0:0:0:0 with HTTP; Sat, 9 May 2020 14:17:59 -0700 (PDT) In-Reply-To: <20200509203336.GN4213@funkthat.com> References: <20200509203336.GN4213@funkthat.com> From: Mateusz Guzik Date: Sat, 9 May 2020 23:17:59 +0200 Message-ID: Subject: Re: patch to make vboxvfs work again To: John-Mark Gurney Cc: vbox@freebsd.org, freebsd-virtualization@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49KKmV0zmYz4LmZ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NvbGMtpG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-9.13), ipnet: 2a00:1450::/32(-2.29), asn: 15169(-0.43), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[c.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-Mailman-Approved-At: Sat, 09 May 2020 23:00:37 +0000 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.32 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 May 2020 21:18:04 -0000 That will do the trick indeed. I don't know about that bcmp thingy, ideally it would be needed. I presume there is a sufficient header mess which makes this to be the easiest hack. On 5/9/20, John-Mark Gurney wrote: > Hello virtualbox maintainer(s), > > Attached is a patch to make VirtualBox vboxvfs work again. I've only > tested under -current. > > mjg, what is the correct way to make this patch work on past versions > of FreeBSD? would a simple #ifdef VFS_VOP_VECTOR_REGISTER wrapper > around the call work? > > Thanks. > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > -- Mateusz Guzik