From owner-svn-src-all@FreeBSD.ORG  Wed Jul 10 08:45:20 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E60AD287;
 Wed, 10 Jul 2013 08:45:20 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au
 [211.29.132.249])
 by mx1.freebsd.org (Postfix) with ESMTP id 5576B1C7A;
 Wed, 10 Jul 2013 08:45:20 +0000 (UTC)
Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au
 (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23])
 by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 7D9051041279;
 Wed, 10 Jul 2013 18:45:17 +1000 (EST)
Date: Wed, 10 Jul 2013 18:45:17 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Aleksandr Rybalko <ray@freebsd.org>
Subject: Re: svn commit: r252425 - head/sys/arm/arm
In-Reply-To: <20130708132052.f9757df88ede1b087de9da8c@freebsd.org>
Message-ID: <20130710184356.R1991@besplex.bde.org>
References: <201306301952.r5UJqfwf010873@svn.freebsd.org>
 <20130701113808.F894@besplex.bde.org>
 <20130708132052.f9757df88ede1b087de9da8c@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.0 cv=eqSHVfVX c=1 sm=1 a=tB-szSHScXMA:10
 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=E11o_6pwCccA:10
 a=i2sZn5OXAAAA:8 a=UzOYU2gb_QF09RkQxBUA:9 a=CjuIK1q_8ugA:10
 a=PObHtDWs1CoA:10 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jul 2013 08:45:21 -0000

On Mon, 8 Jul 2013, Aleksandr Rybalko wrote:

> On Mon, 1 Jul 2013 11:56:25 +1000 (EST)
> Bruce Evans <brde@optusnet.com.au> wrote:
>
>> On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
>>
>>> Log:
>>>  Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
>>>
>>>  Submitted by:	Ruslan Bukin <br@bsdpad.com>
>>>
>>> Modified:
>>>  head/sys/arm/arm/generic_timer.c
>>>
>>> Modified: head/sys/arm/arm/generic_timer.c
>>> ==============================================================================
>>> --- head/sys/arm/arm/generic_timer.c	Sun Jun 30 19:36:17 2013	(r252424)
>>> +++ head/sys/arm/arm/generic_timer.c	Sun Jun 30 19:52:41 2013	(r252425)
>>> @@ -66,7 +66,22 @@ __FBSDID("$FreeBSD$");
>>> #define	GENERIC_TIMER_REG_CTRL		0
>>> #define	GENERIC_TIMER_REG_TVAL		1
>>>
>>> -#define	CNTPSIRQ	29
>>> +#define	GENERIC_TIMER_CNTKCTL_PL0PTEN	(1 << 9) /* Physical timer registers
>>> +						    access from PL0 */
>>> +#define	GENERIC_TIMER_CNTKCTL_PL0VTEN	(1 << 8) /* Virtual timer registers
>>
>> With names like these, the magic numbers are better.  The prefix name
>> GENERIC_TIMER is especially bad.  GT would be good.
>
> Changed in r252780.

Thanks.  It looks OK now.

Bruce