From nobody Sat Jun 28 02:04:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTbMm49jDz60Ylc; Sat, 28 Jun 2025 02:04:36 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTbMm2zTyz3W6F; Sat, 28 Jun 2025 02:04:36 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751076276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0F3uC/fR4ifpEAgpUjom4ajU41EU6OGhCDMV2W/4Q5M=; b=j4JnX2gbWWd2PkCJWAHsi0iJXhlDEfsN8rOn4tdlTB7+P3WmEN3JrqhUvfjcB/fgnRyUwm rGEwRNV7BVtvcGNZYuEP6H1phOBPyotLPd4EUsZ+saUV35uZ8hunKde81ITW1bb8dgsfN9 swMvFQwFR6TXFoVKvtMDKKa1VpH03yyOFzg8jo0ffTsMvFtrEfqex3fP4AttYqORZEi9ot hvc/Oei0+W2pCkNwRgC2GYQk/AH2OocX9U4X2rdaPxRK0pG9p1ZoxnLW9HnazWUA1xMdvP /3LECflC+ipwtst3iThN1LgaUJzrVjtAfo4Mu7NDBHV68yLeUHcAA9J/T7D5aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751076276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0F3uC/fR4ifpEAgpUjom4ajU41EU6OGhCDMV2W/4Q5M=; b=Qff5Urja0WQnRcsGnPpmO7Ey/qXVYF+LtQZ8rvlhNHt+Vn36Hraax2cv4HFSqm0JerMrBm Mv4JTp//pNTL04+wYTUSYh1iSM0y0WVYZdO2EKJ3FiDKMc4dNKoioF9579GnYUrRy/QlBd dkOOSxcuUnR/T5MbRwvwOQSY/7O/4kuUxCDV2NWcr8Jii8ya4avSwf2i9kBKsA5LYBm75J Xby3Oltqd7DoBR3xpqSchaiKBuSiHMRmiNAds43LAk0pomVg5izvqgpdrMeQcMRfns8HC3 88SBth+Qq1M/CwJo39WTvvGb6UPhGSL6XifUui/MJDzH+Ql8scqu6kQxLoCEww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751076276; a=rsa-sha256; cv=none; b=WCL8ib6abuntRT61kg19urYZlqLEIy7ET+KsCzA2R1K4lESNdMB84PDcBkiIREdZvIYWdi Jts+40UDuUtLkkE18tf5PzOsGO1/w+0f+et+GcM/gC91qImZYnceWLWDfLHbXyj93t1KTI 52z1O2wRRM3VkLP4FwbDb96s3DGnW+b2+XrAA3QrKNjAAmZiT1zEpx5rL6KI/rkd3ejHGY 1MTCULTOdxtcsnGDkC0NYBVSl7B0nk3ySV4DiVRRpEmrRBgraYaTlVmdIBsx7dGm6Bze2m K6yi8dcy3dHcqll5wbRkvjzK2cTYSdspJc827Gve0gs+PWnbrlw/rhXvpXrbxw== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:60aa:9198:e79f:6691]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bTbMl5vC2zMNk; Sat, 28 Jun 2025 02:04:35 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: 89f6eb0a61cb - main - tcp: restrict the contents of tcp_timer.h to the kernel context From: Michael Tuexen In-Reply-To: Date: Sat, 28 Jun 2025 04:04:33 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202506261609.55QG9odv049208@gitrepo.freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3826.600.51.1.1) > On 28. Jun 2025, at 00:34, Charlie Li wrote: >=20 > Michael Tuexen wrote: >> tcp: restrict the contents of tcp_timer.h to the kernel context >> The header file contains only stuff relevant in the kernel = context. >> Reviewed by: glebius, rscheff, Peter Lei, imp >> Sponsored by: Netflix, Inc. >> Differential Revision: https://reviews.freebsd.org/D50912 >> --- >> sys/netinet/tcp_timer.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/sys/netinet/tcp_timer.h b/sys/netinet/tcp_timer.h >> index 875f1584988c..a145782ba82d 100644 >> --- a/sys/netinet/tcp_timer.h >> +++ b/sys/netinet/tcp_timer.h >> @@ -32,6 +32,8 @@ >> #ifndef _NETINET_TCP_TIMER_H_ >> #define _NETINET_TCP_TIMER_H_ >> +#ifdef _KERNEL >> + >> /* >> * The TCPT_REXMT timer is used to force retransmissions. >> * The TCP has the TCPT_REXMT timer set whenever segments >> @@ -133,8 +135,6 @@ >> (tv) =3D (tvmax); \ >> } while(0) >> -#ifdef _KERNEL >> - >> #define TP_KEEPINIT(tp) ((tp)->t_keepinit ? (tp)->t_keepinit : = tcp_keepinit) >> #define TP_KEEPIDLE(tp) ((tp)->t_keepidle ? (tp)->t_keepidle : = tcp_keepidle) >> #define TP_KEEPINTVL(tp) ((tp)->t_keepintvl ? (tp)->t_keepintvl : = tcp_keepintvl) > This broke net-mgmt/net-snmp, which uses at least TCPTV_MIN and = TCPTV_REXMTMAX. Hi Charlie, why is net-mgmt/net-snmp interested in the default value of the sysctl = variables net.inet.tcp.rexmit_min and net.inet.tcp.tcp_rexmit_max and not in the = current value of these sysctl variables? This does not make sense to me... Best regards Michael >=20 > --=20 > Charlie Li > ...nope, still don't have an exit line. >=20