From owner-cvs-all@FreeBSD.ORG Sat Sep 27 08:52:37 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 018891065688; Sat, 27 Sep 2008 08:52:37 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DF2908FC12; Sat, 27 Sep 2008 08:52:36 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8R8qas7036271; Sat, 27 Sep 2008 08:52:36 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8R8qaqr036266; Sat, 27 Sep 2008 08:52:36 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200809270852.m8R8qaqr036266@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Sat, 27 Sep 2008 08:51:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 mem.c src/sys/arm/arm mem.c src/sys/cam/scsi scsi_sa.c scsi_ses.c scsi_target.c src/sys/cddl/contrib/opensolaris/uts/common/dtrace dtrace.c src/sys/contrib/ipfilter/netinet ip_compat.h src/sys/contrib/pf/net pf_ioctl.c src/sys/dev/agp ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2008 08:52:37 -0000 ed 2008-09-27 08:51:18 UTC FreeBSD src repository Modified files: sys/amd64/amd64 mem.c sys/arm/arm mem.c sys/cam/scsi scsi_sa.c scsi_ses.c scsi_target.c sys/cddl/contrib/opensolaris/uts/common/dtrace dtrace.c sys/contrib/ipfilter/netinet ip_compat.h sys/contrib/pf/net pf_ioctl.c sys/dev/agp agp.c sys/dev/amr amr.c sys/dev/arcmsr arcmsr.c sys/dev/asr asr.c sys/dev/ata atapi-tape.c sys/dev/atkbdc psm.c sys/dev/bktr bktr_os.c sys/dev/ce if_ce.c sys/dev/cp if_cp.c sys/dev/cpuctl cpuctl.c sys/dev/ctau if_ct.c sys/dev/drm drm_drv.c drm_fops.c sys/dev/fb fb.c vgareg.h sys/dev/firewire firewire.h fwdev.c sys/dev/hptiop hptiop.c sys/dev/iir iir_ctrl.c sys/dev/iscsi/initiator isc_cam.c iscsi.c sys/dev/isp isp_freebsd.c sys/dev/joy joy.c sys/dev/kbd kbd.c sys/dev/mlx mlx.c sys/dev/mly mly.c sys/dev/mse mse.c sys/dev/pbio pbio.c sys/dev/powermac_nvram powermac_nvram.c sys/dev/ppbus lpt.c pcfclock.c ppi.c sys/dev/rp rpvar.h sys/dev/sound/midi sequencer.c sys/dev/speaker spkr.c sys/dev/streams streams.c sys/dev/tdfx tdfx_pci.c sys/dev/twa tw_osl_freebsd.c sys/dev/twe twe_freebsd.c sys/dev/usb ucomvar.h ufm.c ugen.c uhid.c ulpt.c ums.c urio.c usb.c uscanner.c sys/dev/xen/console console.c sys/i386/bios apm.c smapi.c sys/i386/i386 mem.c sys/ia64/ia64 mem.c sys/kern kern_conf.c sys/mips/mips mem.c sys/net if.c if_tap.c if_tun.c sys/netgraph/bluetooth/drivers/ubtbcmfw ubtbcmfw.c sys/netsmb smb_dev.c sys/pc98/cbus gdc.c olpt.c sys/powerpc/powerpc mem.c sys/sparc64/sparc64 mem.c Log: SVN rev 183397 on 2008-09-27 08:51:18Z by ed Replace all calls to minor() with dev2unit(). After I removed all the unit2minor()/minor2unit() calls from the kernel yesterday, I realised calling minor() everywhere is quite confusing. Character devices now only have the ability to store a unit number, not a minor number. Remove the confusion by using dev2unit() everywhere. This commit could also be considered as a bug fix. A lot of drivers call minor(), while they should actually be calling dev2unit(). In -CURRENT this isn't a problem, but it turns out we never had any problem reports related to that issue in the past. I suspect not many people connect more than 256 pieces of the same hardware. Reviewed by: kib Revision Changes Path 1.124 +4 -4 src/sys/amd64/amd64/mem.c 1.6 +4 -4 src/sys/arm/arm/mem.c 1.114 +4 -4 src/sys/cam/scsi/scsi_sa.c 1.39 +1 -1 src/sys/cam/scsi/scsi_ses.c 1.75 +1 -1 src/sys/cam/scsi/scsi_target.c 1.7 +3 -3 src/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c 1.37 +1 -1 src/sys/contrib/ipfilter/netinet/ip_compat.h 1.36 +2 -2 src/sys/contrib/pf/net/pf_ioctl.c 1.60 +1 -1 src/sys/dev/agp/agp.c 1.87 +2 -2 src/sys/dev/amr/amr.c 1.28 +3 -3 src/sys/dev/arcmsr/arcmsr.c 1.86 +1 -1 src/sys/dev/asr/asr.c 1.109 +1 -1 src/sys/dev/ata/atapi-tape.c 1.99 +2 -2 src/sys/dev/atkbdc/psm.c 1.55 +14 -14 src/sys/dev/bktr/bktr_os.c 1.12 +3 -3 src/sys/dev/ce/if_ce.c 1.36 +3 -3 src/sys/dev/cp/if_cp.c 1.3 +2 -2 src/sys/dev/cpuctl/cpuctl.c 1.37 +3 -3 src/sys/dev/ctau/if_ct.c 1.11 +1 -1 src/sys/dev/drm/drm_drv.c 1.4 +1 -1 src/sys/dev/drm/drm_fops.c 1.35 +1 -1 src/sys/dev/fb/fb.c 1.9 +1 -1 src/sys/dev/fb/vgareg.h 1.22 +1 -1 src/sys/dev/firewire/firewire.h 1.53 +1 -1 src/sys/dev/firewire/fwdev.c 1.4 +1 -1 src/sys/dev/hptiop/hptiop.c 1.18 +5 -5 src/sys/dev/iir/iir_ctrl.c 1.2 +1 -1 src/sys/dev/iscsi/initiator/isc_cam.c 1.3 +8 -8 src/sys/dev/iscsi/initiator/iscsi.c 1.148 +1 -1 src/sys/dev/isp/isp_freebsd.c 1.55 +2 -2 src/sys/dev/joy/joy.c 1.49 +2 -2 src/sys/dev/kbd/kbd.c 1.56 +3 -3 src/sys/dev/mlx/mlx.c 1.46 +2 -2 src/sys/dev/mly/mly.c 1.76 +2 -2 src/sys/dev/mse/mse.c 1.11 +2 -2 src/sys/dev/pbio/pbio.c 1.3 +1 -1 src/sys/dev/powermac_nvram/powermac_nvram.c 1.42 +6 -6 src/sys/dev/ppbus/lpt.c 1.21 +7 -7 src/sys/dev/ppbus/pcfclock.c 1.43 +5 -5 src/sys/dev/ppbus/ppi.c 1.11 +1 -1 src/sys/dev/rp/rpvar.h 1.30 +2 -2 src/sys/dev/sound/midi/sequencer.c 1.77 +4 -4 src/sys/dev/speaker/spkr.c 1.59 +2 -2 src/sys/dev/streams/streams.c 1.41 +3 -3 src/sys/dev/tdfx/tdfx_pci.c 1.10 +2 -2 src/sys/dev/twa/tw_osl_freebsd.c 1.45 +2 -2 src/sys/dev/twe/twe_freebsd.c 1.13 +3 -3 src/sys/dev/usb/ucomvar.h 1.37 +1 -1 src/sys/dev/usb/ufm.c 1.113 +2 -2 src/sys/dev/usb/ugen.c 1.98 +1 -1 src/sys/dev/usb/uhid.c 1.81 +2 -2 src/sys/dev/usb/ulpt.c 1.102 +1 -1 src/sys/dev/usb/ums.c 1.49 +1 -1 src/sys/dev/usb/urio.c 1.123 +1 -1 src/sys/dev/usb/usb.c 1.94 +1 -1 src/sys/dev/usb/uscanner.c 1.5 +1 -1 src/sys/dev/xen/console/console.c 1.152 +1 -1 src/sys/i386/bios/apm.c 1.15 +1 -1 src/sys/i386/bios/smapi.c 1.118 +5 -5 src/sys/i386/i386/mem.c 1.22 +3 -3 src/sys/ia64/ia64/mem.c 1.223 +3 -3 src/sys/kern/kern_conf.c 1.2 +2 -2 src/sys/mips/mips/mem.c 1.287 +2 -2 src/sys/net/if.c 1.76 +17 -17 src/sys/net/if_tap.c 1.167 +6 -6 src/sys/net/if_tun.c 1.19 +2 -2 src/sys/netgraph/bluetooth/drivers/ubtbcmfw/ubtbcmfw.c 1.35 +2 -2 src/sys/netsmb/smb_dev.c 1.52 +1 -1 src/sys/pc98/cbus/gdc.c 1.32 +5 -5 src/sys/pc98/cbus/olpt.c 1.3 +3 -3 src/sys/powerpc/powerpc/mem.c 1.20 +2 -2 src/sys/sparc64/sparc64/mem.c