From owner-freebsd-testing@freebsd.org Wed Jul 29 19:02:58 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71A279AE8A6 for ; Wed, 29 Jul 2015 19:02:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com [IPv6:2607:f8b0:4003:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32674FE2; Wed, 29 Jul 2015 19:02:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obnw1 with SMTP id w1so14372001obn.3; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=RRMO8HJQl+8DYif/KD26ANdVawP15BuuAfAh0LY4j+w=; b=vizPxfvYEkEF5E+LZC8H6UBu0wjSus6TVahtjyBuaEezxvbtMoCLHTRs7E/4RszuIo F9TF4l+EqWwLw17vpA997Z+Vz5U3czKxy0A6P1YcvouC4mqemN+vH95AlY+Ij7GWrpoK ofaTNBILJx98YU67E2QD2tDaAO0BpTmp8xbjIs1veNv+mNQrfEbGs0IOzRa95/B7jQGA t2g0RggcMyRHclVak3QM5TO1Cz8t8wJgFtbKOn89jv9jD4YljfDvJ83UeP4H+IpCR2Ij 2OtRV7oggJPTRnGOlrhAGO26mECbszaGQolMaqNLR6oZU3wC5IhZ6TgrN6H8/ZmwNILi krCQ== MIME-Version: 1.0 X-Received: by 10.60.79.193 with SMTP id l1mr41123720oex.60.1438196577567; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.80.4 with HTTP; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) In-Reply-To: References: Date: Wed, 29 Jul 2015 13:02:57 -0600 X-Google-Sender-Auth: 058g-S6FHt-ozQH9T0lPFwTSCTc Message-ID: Subject: Re: NVMe unit tests From: Alan Somers To: Jim Harris Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 19:02:58 -0000 On Wed, Jul 29, 2015 at 11:59 AM, Jim Harris wrote: > Hi, > > I have a CUnit-based infrastructure with quite a few unit tests for the > FreeBSD nvme driver. It enables testing a number of corner cases within > the driver without requiring real hardware and stubbing kernel behavior in > some cases to induce the corner cases. Which leads me to a few questions: > > 1) Is there interest here in having this pushed into HEAD? Or would a user > branch be more appropriate? > Head would be ideal. The tests won't get run if they stay in a user branch. > 2) Where in the tree should I put it? In our internal repo, I have it > under tools/regression/nvme, but maybe sys/dev/nvme/tests is more > appropriate? > Ngie, jmmv, and I debated this awhile back. We concluded that the way our build system works, it isn't appropriate to put ATF tests in sys. Instead, they should go in tests/sys/X, where X mirrors the location of the code in sys. For nvme, that would be tests/sys/dev/nvme. Kyua doesn't natively understand CUnit. So you have two options: run the tests with the plain test adapter, or convert them all to ATF-C tests. The main disadvantage to the plain test adapter is that Kyua won't be aware of the detailed test results. For example, if you have 500 CUnit test cases, Kyua will only report whether the whole suite passed or failed rather than whether each test case passed or failed. -Alan > > Feedback is welcome. > > Thanks, > > -Jim > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org" >