From owner-freebsd-hackers@FreeBSD.ORG Fri Aug 20 18:25:58 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C729816A4CE for ; Fri, 20 Aug 2004 18:25:58 +0000 (GMT) Received: from coverity.dreamhost.com (coverity.dreamhost.com [66.33.192.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id B905D43D2F for ; Fri, 20 Aug 2004 18:25:58 +0000 (GMT) (envelope-from tedu@coverity.com) Received: from coverity.com (dsl093-171-098.sfo4.dsl.speakeasy.net [66.93.171.98]) by coverity.dreamhost.com (Postfix) with ESMTP id 81BE090887 for ; Fri, 20 Aug 2004 11:25:58 -0700 (PDT) Message-ID: <412640EA.4090403@coverity.com> Date: Fri, 20 Aug 2004 11:20:26 -0700 From: Ted Unangst User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040429 X-Accept-Language: en-us, en MIME-Version: 1.0 To: hackers@freebsd.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sat, 21 Aug 2004 02:56:03 +0000 Subject: malloc null bugs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2004 18:25:58 -0000 Found during analysis with Coverity's tools. FreeBSD 4.10 atapi-cd.c, everywhere. I understand there was some question of not being to deal with failure gracefully in ata, but many of these are in functions like ioctl which can easily report errors. igmp.c:find_rti mii.c:mii_phy_probe. device_add_child can also fail, and is not checked. pst-raid.c:pst_add_raid if_dc.c:dc_decode_leaf_mii if_ti:ti_setmulti if_sk.c:sk_vpd_read uipc_syscalls.c:sf_buf_init mpt.c:mpt_send_port_enable, mpt_get_request can fail if_wi_pci.c:attach, bus_alloc_resource may fail