From owner-freebsd-net@FreeBSD.ORG  Fri Apr  2 17:45:06 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7313106564A
	for <freebsd-net@freebsd.org>; Fri,  2 Apr 2010 17:45:06 +0000 (UTC)
	(envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3])
	by mx1.freebsd.org (Postfix) with ESMTP id A1B3F8FC18
	for <freebsd-net@freebsd.org>; Fri,  2 Apr 2010 17:45:06 +0000 (UTC)
Received: from localhost (amavis.fra.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 11B2A41C798;
	Fri,  2 Apr 2010 19:45:06 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([192.168.74.103])
	by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id pZX+8DQuRvsu; Fri,  2 Apr 2010 19:45:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 5C44941C7A7; Fri,  2 Apr 2010 19:45:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 040674448EC;
	Fri,  2 Apr 2010 17:40:58 +0000 (UTC)
Date: Fri, 2 Apr 2010 17:40:58 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com>
In-Reply-To: <s2j9a542da31004021029u531d4955u9fa1a1f892e0e63f@mail.gmail.com>
Message-ID: <20100402173951.K40281@maildrop.int.zabbadoz.net>
References: <9a542da31003190453s1e7598efr8f35f525871f5589@mail.gmail.com> 
	<20100402170740.N40281@maildrop.int.zabbadoz.net>
	<s2j9a542da31004021029u531d4955u9fa1a1f892e0e63f@mail.gmail.com>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-975403252-1270230058=:40281"
Cc: freebsd-net <freebsd-net@freebsd.org>
Subject: Re: Is this correct?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 17:45:07 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-975403252-1270230058=:40281
Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 2 Apr 2010, Ermal Lu=E7i wrote:

Hi,

>>> Shouldn't this check be
>>> if (m->m_len > sizeof (struct ip)) {
>>> instead of
>>> if (m->m_len < sizeof (struct ip)) {
>>
>> Should it be > or >=3D ?
>>
> I would say >=3D since that is what logic assumes!

Yeah. Commit that.

/bz

--=20
Bjoern A. Zeeb         It will not break if you know what you are doing.
--0-975403252-1270230058=:40281--