From owner-svn-src-all@freebsd.org Thu Feb 15 03:39:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03C36F1B397 for ; Thu, 15 Feb 2018 03:39:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EFA47F7B0 for ; Thu, 15 Feb 2018 03:39:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x229.google.com with SMTP id 193so14837425iti.1 for ; Wed, 14 Feb 2018 19:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LC2xR4FMqy9J6AA4ctQRdfbG9xgivjbDZQhPLrKOPZs=; b=Q1FZU97/OthCitbvMiQvY67xhHk39/XxIadKkiMAkqHip+c1WkBe3lf5lJPgDsvPTR qICVpXEd0qOPey1uGcsmat0McblfRlwNNsOFvAAt/gDAe+erHRBXQ9WSSFVujZXj8937 vUa0X9elK9v2jAHB7iDDQdohN9RyLN6usvYtgzfrmBJkQus4ApR7p0pDvA9UP99keeNB TWtkGD/61fLXV2WksUtOreF3RanwEGOtlWDGPyp//UWa6xLoXPBDn5yIUTDyNFTD5pci f8fhsswnSOdyWwm4OUm3WUZ382UAJQavPfHzhWc6MZ4pXkGsS1Fq3vdUxAzPBN5Mg/rQ m18A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LC2xR4FMqy9J6AA4ctQRdfbG9xgivjbDZQhPLrKOPZs=; b=gM6QHqL+6l89Ix2X5PAU6PR0ocvtWs3fL5AD6u47GVmYMpzBqxYiD/caRz9pJUZKl1 Hf2CDN2CtjGMTzko3NyZaUgpjFy/5yh2CadSQOJGdzJxT9/nVSZ5djGOx3uKmxLpjW+z lDUV3FXuboxUKs40rNjJs4VGJBsAC9F4p5SEpVYGHA3dOv0tEiNsOWSSsju7eHjHSAZL CLAxl4xHDcyvtQcbaHiYsDgM/nn1yJiome4xaK9b1sGDx/nqJsJRNpdJuibl6HGuqE1G fYbwCJ8UQpcO88O0veLCMWGjmZiCUioHP18/taeQpJ6GeQEMyM0SKEWs4/wlAl+B80Tl gDFw== X-Gm-Message-State: APf1xPDhN2zD8+c+s1goQGN6CfVJIaCXfitAiFx5Ywix3KgisKTzd2Du Duzz2urW7MIePh3fr/RTAWRSfXVj+F+LMjvQ7Sijcg== X-Google-Smtp-Source: AH8x224m7KgYWrPHB2mrZtA9jJQa1L1jXbURmlfujLGvZU/tXx3sKSVu/B1nUmsBAtqWCrgdNi32HfWD6cn6xQBIw+I= X-Received: by 10.36.80.17 with SMTP id m17mr779905itb.64.1518665990395; Wed, 14 Feb 2018 19:39:50 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Wed, 14 Feb 2018 19:39:49 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:c5d:377:1ec2:48fe] Received: by 10.79.201.67 with HTTP; Wed, 14 Feb 2018 19:39:49 -0800 (PST) In-Reply-To: <201802150322.w1F3Mrie018786@repo.freebsd.org> References: <201802150322.w1F3Mrie018786@repo.freebsd.org> From: Warner Losh Date: Wed, 14 Feb 2018 20:39:49 -0700 X-Google-Sender-Auth: aL3iPQDiVL6pdXlnKttV5qb78CQ Message-ID: Subject: Re: svn commit: r329296 - head/sbin/devd To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 03:39:52 -0000 On Feb 14, 2018 8:23 PM, "Eitan Adler" wrote: Author: eadler Date: Thu Feb 15 03:22:53 2018 New Revision: 329296 URL: https://svnweb.freebsd.org/changeset/base/329296 Log: devd: don't pass &fds in useless parameters to select(2) select(2) should be declared as restrict. In addition the only fd in the fdset is open O_RDONLY, and it's not a socket that can provide OOB notifications, Reviewed by: ian, imp, vangyzen Don't put my name on this. I specifically and clearly objected to the change anf tld yoy not to do it. Warner Modified: head/sbin/devd/devd.cc Modified: head/sbin/devd/devd.cc ============================================================ ================== --- head/sbin/devd/devd.cc Thu Feb 15 03:22:04 2018 (r329295) +++ head/sbin/devd/devd.cc Thu Feb 15 03:22:53 2018 (r329296) @@ -1021,7 +1021,7 @@ event_loop(void) tv.tv_usec = 0; FD_ZERO(&fds); FD_SET(fd, &fds); - rv = select(fd + 1, &fds, &fds, &fds, &tv); + rv = select(fd + 1, &fds, NULL, NULL, &tv); // No events -> we've processed all pending events if (rv == 0) { devdlog(LOG_DEBUG, "Calling daemon\n");