Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Feb 2014 14:03:53 +0100 (CET)
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/186688: [patch] devel/libslang2: fix iconv detection
Message-ID:  <201402121303.s1CD3r29084883@kalimero.tijl.coosemans.org>
Resent-Message-ID: <201402121310.s1CDA02a014591@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         186688
>Category:       ports
>Synopsis:       [patch] devel/libslang2: fix iconv detection
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 12 13:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Tijl Coosemans
>Release:        FreeBSD 11.0-CURRENT i386
>Organization:
>Environment:
>Description:
The configure script has some simple tests that pick up libiconv.so when
it is installed on FreeBSD 10, but the base system iconv should be used
instead.

The attached patch adds --without-iconv to CONFIGURE_ARGS so these tests
are bypassed and the configure script falls back on a more standard iconv
test that does work correctly.
>How-To-Repeat:
>Fix:

--- libslang2.patch begins here ---
Index: devel/libslang2/Makefile
===================================================================
--- devel/libslang2/Makefile	(revision 343867)
+++ devel/libslang2/Makefile	(working copy)
@@ -2,7 +2,7 @@
 
 PORTNAME=	libslang2
 PORTVERSION=	2.2.4
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	devel
 MASTER_SITES=	ftp://space.mit.edu/pub/davis/slang/v${PORTVERSION:R}/ \
 		ftp://ftp.fu-berlin.de/pub/unix/misc/slang/v${PORTVERSION:R}/ \
@@ -22,7 +22,7 @@ GNU_CONFIGURE=	yes
 MAKE_JOBS_UNSAFE=	yes
 PLIST_SUB+=	SHLIB_VERSION=${PORTVERSION}
 
-CONFIGURE_ARGS+=--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig
+CONFIGURE_ARGS=	--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig --without-iconv
 
 ALL_TARGET=	all static
 INSTALL_TARGET=	install install-static
@@ -42,7 +42,6 @@ PCRE_CONFIGURE_WITH=	pcre
 PCRE_LIB_DEPENDS=	libpcre.so:${PORTSDIR}/devel/pcre
 PNG_CONFIGURE_WITH=	png
 PNG_LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png
-ICONV_CONFIGURE_WITH=	iconv
 ICONV_USES=		iconv
 ONIG_CONFIGURE_WITH=	onig
 ONIG_LIB_DEPENDS=	libonig.so:${PORTSDIR}/devel/oniguruma4
--- libslang2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402121303.s1CD3r29084883>