From owner-cvs-all@FreeBSD.ORG  Mon Jul 18 09:06:46 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DBA1D1065670;
	Mon, 18 Jul 2011 09:06:46 +0000 (UTC)
	(envelope-from jaap@bartok.nlnetlabs.nl)
Received: from bartok.nlnetlabs.nl (bartok.nlnetlabs.nl
	[IPv6:2001:7b8:206:1:216:76ff:feb8:3c02])
	by mx1.freebsd.org (Postfix) with ESMTP id 710108FC13;
	Mon, 18 Jul 2011 09:06:46 +0000 (UTC)
Received: from bartok.nlnetlabs.nl (localhost [127.0.0.1])
	by bartok.nlnetlabs.nl (8.14.5/8.14.5) with ESMTP id p6I96cSH033317;
	Mon, 18 Jul 2011 11:06:38 +0200 (CEST)
	(envelope-from jaap@bartok.nlnetlabs.nl)
Message-Id: <201107180906.p6I96cSH033317@bartok.nlnetlabs.nl>
To: Doug Barton <dougb@FreeBSD.org>
In-reply-to: <4E20C588.5010409@FreeBSD.org>
References: <201107152055.p6FKt0ap062328@repoman.freebsd.org>
	<4E20C588.5010409@FreeBSD.org>
Comments: In-reply-to Doug Barton <dougb@FreeBSD.org>
	message dated "Fri, 15 Jul 2011 15:56:08 -0700."
Date: Mon, 18 Jul 2011 11:06:38 +0200
From: Jaap Akkerhuis <jaap@NLnetLabs.nl>
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7
	(bartok.nlnetlabs.nl [127.0.0.1]);
	Mon, 18 Jul 2011 11:06:38 +0200 (CEST)
X-Spam-Status: No, score=-2.4 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	MISSING_MID autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on bartok.nlnetlabs.nl
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Julien Laffaye <jlaffaye@FreeBSD.org>
Subject: Re: cvs commit: ports/dns/opendnssec Makefile distinfo pkg-plist
	ports/dns/opendnssec/files opendnssec.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jul 2011 09:06:47 -0000

Hi Doug,
    
    I've attached some (hopefully) improvements to the rc.d script. First
    the minor issues:
    
    1. It needs a $FreeBSD$

Oops, didn't realise that.

    2. We prefer ports scripts to REQUIRE: LOGIN unless there is a reason it
    needs to start earlier.

Yes, I was wondering whether I should do that or not.

    3. Minor typo and whitespace twiddles
    
    More substantively, I compressed the start_ and stop_ methods, but this
    should be tested. It certainly _should_ work. :) It's fine to have all
    the extra_commands, but they won't be functional unless they also have
    methods associated with them. Finally, I left the procname assignment in
    there, but it's not at all clear to me where $opendnssec_procname is
    defined, or what that procname is going to be used for. It can probably
    just be deleted.
    
Thanks a bunch. I'll test this out to be sure. Yes you might have
guessed, I incoporated this from a user who apparently based this
on the nsd rc.d script. I'll have a look at that one as well.

	jaap