Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Feb 2015 12:01:53 +0000 (UTC)
From:      John Marino <marino@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r379903 - head/science/bddsolve
Message-ID:  <201502251201.t1PC1r9W066998@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marino
Date: Wed Feb 25 12:01:52 2015
New Revision: 379903
URL: https://svnweb.freebsd.org/changeset/ports/379903
QAT: https://qat.redports.org/buildarchive/r379903/

Log:
  science/bddsolve: Set environment, use CXXFLAGS, cleanup
  
  This port had two main problems:
    1) failure to set the enviroment in the build target
    2) failure to use CXXFLAGS with CXX
  
  While fixing those, clean up a bit:
    3) remove <pre>,<post> by using BROKEN_powerpc instead
    4) use CFLAGS+= to augment CFLAGS
    5) use LDFLAGS+= to augment LDFLAGS
    6) simplify do-build target accordingly
  
  Approved by:	just fix it

Modified:
  head/science/bddsolve/Makefile

Modified: head/science/bddsolve/Makefile
==============================================================================
--- head/science/bddsolve/Makefile	Wed Feb 25 11:46:23 2015	(r379902)
+++ head/science/bddsolve/Makefile	Wed Feb 25 12:01:52 2015	(r379903)
@@ -16,18 +16,14 @@ LIB_DEPENDS+=	libbdd.so:${PORTSDIR}/scie
 
 USES=		zip
 NO_WRKSUBDIR=	yes
+CFLAGS+=	-I${LOCALBASE}/include -I${WRKSRC}/include
+LDFLAGS+=	-L${LOCALBASE}/lib -lbdd -lboost_program_options
+BROKEN_powerpc=	Does not compile due to running out of virtual memory
 
 OPTIONS_DEFINE=	EXAMPLES
 
-.include <bsd.port.pre.mk>
-
-.if ${ARCH} == "powerpc"
-BROKEN=		Does not compile on powerpc: runs out of virtual memory
-.endif
-
 do-build:
-	${CXX} ${CFLAGS} -I${LOCALBASE}/include -I${WRKSRC}/include \
-		${LDFLAGS} -L${LOCALBASE}/lib -lbdd -lboost_program_options \
+	${SETENV} ${MAKE_ENV} ${CXX} ${CXXFLAGS} ${LDFLAGS} \
 		-o ${WRKSRC}/bddsolve ${WRKSRC}/src/bddsolve.cpp
 
 do-install:
@@ -36,4 +32,4 @@ do-install:
 	${INSTALL_DATA} ${WRKSRC}/example/reach.b ${STAGEDIR}${EXAMPLESDIR}
 	${INSTALL_DATA} ${WRKSRC}/example/sat.b ${STAGEDIR}${EXAMPLESDIR}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502251201.t1PC1r9W066998>