From owner-freebsd-net@FreeBSD.ORG  Thu Feb 15 18:03:10 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5A01116A400
	for <freebsd-net@freebsd.org>; Thu, 15 Feb 2007 18:03:10 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outV.internet-mail-service.net (outV.internet-mail-service.net
	[216.240.47.245])
	by mx1.freebsd.org (Postfix) with ESMTP id 376CD13C4BB
	for <freebsd-net@freebsd.org>; Thu, 15 Feb 2007 18:03:10 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Thu, 15 Feb 2007 09:39:37 -0800
Received: from [192.168.2.5] (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id A1EBA125B39;
	Thu, 15 Feb 2007 10:03:07 -0800 (PST)
Message-ID: <45D4A05B.4090509@elischer.org>
Date: Thu, 15 Feb 2007 10:03:07 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
MIME-Version: 1.0
To: Andrew Thompson <thompsa@freebsd.org>
References: <45D38AC9.50107@incunabulum.net>
	<20070215095542.GA58929@heff.fud.org.nz>
In-Reply-To: <20070215095542.GA58929@heff.fud.org.nz>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org, Bruce M Simpson <bms@incunabulum.net>
Subject: Re: [PATCH] Updated 802.1p/q patch
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Feb 2007 18:03:10 -0000

Andrew Thompson wrote:
> On Wed, Feb 14, 2007 at 10:18:49PM +0000, Bruce M Simpson wrote:
>> Hi,
>>
>> I have tested my 802.1p input patch with vlans configured. So far so good.
>>
>> It is now available from: 
>> http://people.FreeBSD.org/~bms/dump/latest-8021p.diff
>>
> 
>     /*
>      * If the device did not perform decapsulation of the 802.1q
>      * VLAN header itself, do this now...
>      */
>     if ((ether_type == ETHERTYPE_VLAN) && !(m->m_flags & M_VLANTAG)) {
> 	...
>     }
> 
> Is it possible to move this block into ether_input() above the bridge
> hook? it would be nice if ether_vtag was set consistently early on in
> the game.
> 

yes, I would like the tagging to be done before the bridging so that all packets
being filtered by the bridge are the same.

> 
> cheers,
> Andrew
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"