From owner-svn-ports-head@FreeBSD.ORG  Thu Nov  1 16:35:01 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9D060AF;
 Thu,  1 Nov 2012 16:35:01 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 77E758FC0C;
 Thu,  1 Nov 2012 16:35:00 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jf20so1229433bkc.13
 for <multiple recipients>; Thu, 01 Nov 2012 09:34:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=+C2PKlgUAJf1lftIEE3aGeBzN9LmtCAzLq1vwmyDl7c=;
 b=nr+d0jXLlWjFhPvsbLAfuCghdgXb2oYCY6Jr1HumVD/Cr6SeWRbfPpjDLFxwu3owcN
 iDq2Sv3qEgbdpbzYlcAcRfywgmr+NmNpGxW3V4sKp/H317eN52kqDn4vxTbllnlk/H8y
 4MMEjuQsUoIe2ZArMr/zlx8I0X4NJ4jH+NzwVk2w465eB3l8PdBp1tcjadVq6hf1tdN8
 t65yVJxuC6PjTzkOYvNqUxLLJdnNy5MTiTdDsSccXQwSOXQTWSGVaWuMCSqFNpahJAex
 fvN1mdqFK1kJiSz5+SVomGQq0co3507NI8ANasi2Z9XsW4Bcjm4U4epd5XrRSjuqbOVm
 0FCA==
Received: by 10.204.156.74 with SMTP id v10mr12577115bkw.39.1351787699092;
 Thu, 01 Nov 2012 09:34:59 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.50.197 with HTTP; Thu, 1 Nov 2012 09:34:28 -0700 (PDT)
In-Reply-To: <50929832.9070400@FreeBSD.org>
References: <201211011133.qA1BXdZE082128@svn.freebsd.org>
 <20121101134842.GA13708@FreeBSD.org> <50929832.9070400@FreeBSD.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Thu, 1 Nov 2012 16:34:28 +0000
X-Google-Sender-Auth: oQm-tOX0LJwjwWsnL8TOIPvURtQ
Message-ID: <CADLo838ofnMJqhH18ryM63E+jX+1htJ=r2+aUtiUv44c69z=hg@mail.gmail.com>
Subject: Re: svn commit: r306797 - head/emulators/bochs
To: Guido Falsi <madpilot@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>,
 svn-ports-all@freebsd.org,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2012 16:35:01 -0000

On 1 November 2012 15:41, Guido Falsi <madpilot@freebsd.org> wrote:
> On 11/01/12 14:48, Alexey Dokuchaev wrote:
>> On Thu, Nov 01, 2012 at 11:33:39AM +0000, Guido Falsi wrote:
>>> New Revision: 306797
>>> URL: http://svn.freebsd.org/changeset/ports/306797
>>>
>>> Log:
>>>   - Replace usage of !${PORT_OPTIONS:MFOO} with empty(PORT_OPTIONS:MFOO)
>>
>> Any reason for doing it this way?  AFAIK both forms are equivalent (in fact
>> I prefer the ! one, but with a space after exclamation mark).
>
> I have no preference, but the porter's handbook reports the empty() form
> as THE one. Most ports are following the examples there so I was
> conforming to it.
>
> To tell the truth I'm quite sure that I was the one who wrote the old
> lines when converting it to optionsng, at the time thee porter's
> handbook had still not been updated with optionsng examples.

Both usages are correct, but the empty() syntax was written into the
Porter's Handbook because some complex expressions failed if expressed
as ! ${:M}.

However, when challenged I couldn't reproduce these, so I updated the docs.

http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/172662

It's waiting for anyone with a doc bit :)

Chris