Date: Sun, 21 Nov 2021 19:37:06 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259967] graphics/qgis: broken on CURRENT since intro of llvm13 in base Message-ID: <bug-259967-7788-bw0yG1zH5w@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-259967-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-259967-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259967 Dimitry Andric <dim@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dim@FreeBSD.org --- Comment #3 from Dimitry Andric <dim@FreeBSD.org> --- Created attachment 229644 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D229644&action= =3Dedit Correct parameter type for QgsOgrDataset deleter Here's a patch that should hopefully fix it. I've blindly typed it since my dependencies are still building (it's now chugging through qtwebengine which takes a few hours still). FWIW this changed with https://reviews.llvm.org/D81414 (aka https://github.com/llvm/llvm-project/commit/dbc89028d737), where the constraints on std::shared_ptr were tightened. (See also https://wg21.link/LWG2875) E.g. if you pass an explicit deleter to a std::shared_ptr<T> constructor, a= nd the deleter is a plain function, the function must now have the prototype "= void deleter(T*)". But with this particular issue in qgis, they have "void QgsOgrProviderUtils::releaseDataset( QgsOgrDataset *&ds )", and they attemp= t to 'clear' the passed pointer to null after deletion, which is why they want to use a reference to a QgsOgrDataset pointer instead. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-259967-7788-bw0yG1zH5w>