From nobody Sat May 3 15:20:01 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZqWgQ33QNz5vSnh; Sat, 03 May 2025 15:20:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZqWgQ0jtPz3Kg6; Sat, 03 May 2025 15:20:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746285602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QSLZ91RbnTZFPwhMYLaQ43F8SsdX52KJ7Qf2VB7uPmU=; b=g0FsMaywYIrn/nwRJ4aKNtnGQmtL7xc082Z76PVAa6Ed9AjX/zjyva6ptn3Q204l/OMOEi t12GGgyhe3MdRQbVLriEXE78xFKmLgULXF2jhaRCtb673VoUw3JSUtYjxkUXnot0RLHxsX 0Z/RERHlIq1psv0RJ7D4COkCwWo38p9v/OPtnRJGSD4L8bFBuIXPRM5WKNKmGczfz9G1+i Xo4JKjBvZg1BBuBb88J9YbN4CQ26F2imQNVQGq3kEP1ifE9H6sLGy9TCYHQf4VF0UdJiwc AKdZnT5Z/6Dbok2Olv4WqErqRlj3U6EQRerzgeFDG2/poJGZHHJPbwYESOsOAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746285602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QSLZ91RbnTZFPwhMYLaQ43F8SsdX52KJ7Qf2VB7uPmU=; b=t2U7b+DUtAa+EfmRCoYqqLesZnP6tlSRdPCgBqDMdI8cIiL73Crj+QoTpvEcLURWpDOczb ww4nTram+ohQNhtd3g2MKOQOy5nmc7gQFgqYt0zTwl1jUfuKisQHRYtzN2RCkC2kky5OLi UrCxanth0uHgKSjuGSSsZvDUdGMDzyaAbhzHICryO5UM/iyjThUR7HHiBg26KRXCCNIxZe DXoRK/cszP5rwmqKr1ubMXL1o8Hvk5YkrPP9aLmVxYM24AvKIgqLZAsqBA/gAgah3DNPmL gn8XfIJTewXWxsXXMtT/koIGSNJSoxLKHykrQZjDbkHdjL2zg6zWQGFuPU+4Kg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746285602; a=rsa-sha256; cv=none; b=gXlOvUIRG1Z1Ib9G8eSGWIoYaVw4mAHzxa9ZUtuNfYp/vNGcG2aqyYohOe8hSv8jd0OT2M Wtv0ekbOx/RMWav4fRONruS9uK9B6FURQ9bCR0EIkalcmCxdH+MHArLyaoWsw3+T0hs/h+ 7u47UZ1T5+4pyr1PNJYtoGcnhfDn8m9d4Quw6lsNHluvFvH/TDzEhsEhqKQ4Reh4kbxT+4 f6ons2hZ7fs2NiwCSRZTIwOsAI+xbo7uzeKUAfP9KdvUkJuIFijE2Dg+FcuwxcC9Tkcel5 9i2b8PtC7Hk8E1keV7ddbDNWn4LKJQQ5GwQzwyMx/Zspf9oAENRolmtXzrBSnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZqWgQ0FcHzp51; Sat, 03 May 2025 15:20:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 543FK1mF047966; Sat, 3 May 2025 15:20:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 543FK1Do047961; Sat, 3 May 2025 15:20:01 GMT (envelope-from git) Date: Sat, 3 May 2025 15:20:01 GMT Message-Id: <202505031520.543FK1Do047961@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 2b11b13b04bd - stable/14 - kern_sig.c: add chicken bit for old way of SIGSTOP handling on PT_ATTACH List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2b11b13b04bd4b5a0519850d35b334fe420502ca Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=2b11b13b04bd4b5a0519850d35b334fe420502ca commit 2b11b13b04bd4b5a0519850d35b334fe420502ca Author: Konstantin Belousov AuthorDate: 2025-04-17 11:51:42 +0000 Commit: Konstantin Belousov CommitDate: 2025-05-03 15:19:41 +0000 kern_sig.c: add chicken bit for old way of SIGSTOP handling on PT_ATTACH (cherry picked from commit a6b7d5cddacd4aa14ee058195eedfe207a69029e) --- sys/kern/kern_sig.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index 4df052629828..06da39b8cb33 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -176,6 +176,11 @@ SYSCTL_BOOL(_kern, OID_AUTO, sig_discard_ign, CTLFLAG_RWTUN, "Discard ignored signals on delivery, otherwise queue them to " "the target queue"); +static bool pt_attach_transparent = true; +SYSCTL_BOOL(_debug, OID_AUTO, ptrace_attach_transparent, CTLFLAG_RWTUN, + &pt_attach_transparent, 0, + "Hide wakes from PT_ATTACH on interruptible sleeps"); + SYSINIT(signal, SI_SUB_P1003_1B, SI_ORDER_FIRST+3, sigqueue_start, NULL); /* @@ -2361,7 +2366,8 @@ tdsendsignal(struct proc *p, struct thread *td, int sig, ksiginfo_t *ksi) if (prop & SIGPROP_CONT) sigqueue_delete_stopmask_proc(p); else if (prop & SIGPROP_STOP) { - if ((p->p_flag & P_TRACED) != 0 && + if (pt_attach_transparent && + (p->p_flag & P_TRACED) != 0 && (p->p_flag2 & P2_PTRACE_FSTP) != 0) { td->td_dbgflags |= TDB_FSTP; PROC_SLOCK(p); @@ -3364,7 +3370,7 @@ issignal(struct thread *td) } } - if (false && + if (!pt_attach_transparent && (p->p_flag & (P_TRACED | P_PPTRACE)) == P_TRACED && (p->p_flag2 & P2_PTRACE_FSTP) != 0 && SIGISMEMBER(sigpending, SIGSTOP)) {