From owner-cvs-all Sun Mar 1 04:33:58 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA08505 for cvs-all-outgoing; Sun, 1 Mar 1998 04:33:58 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from news1.gtn.com (news1.gtn.com [192.109.159.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA08488; Sun, 1 Mar 1998 04:33:51 -0800 (PST) (envelope-from andreas@klemm.gtn.com) Received: (from uucp@localhost) by news1.gtn.com (8.8.6/8.8.6) with UUCP id NAA21336; Sun, 1 Mar 1998 13:15:06 +0100 (MET) Received: (from andreas@localhost) by klemm.gtn.com (8.8.8/8.8.7) id MAA11013; Sun, 1 Mar 1998 12:52:19 +0100 (CET) (envelope-from andreas) Message-ID: <19980301125219.14304@klemm.gtn.com> Date: Sun, 1 Mar 1998 12:52:19 +0100 From: Andreas Klemm To: Satoshi Asami Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: Re: cvs commit: ports/misc/xopps Makefile References: <19980228151657.51438@klemm.gtn.com> <199803010934.BAA02393@bubble.didi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199803010934.BAA02393@bubble.didi.com>; from Satoshi Asami on Sun, Mar 01, 1998 at 01:34:07AM -0800 X-Disclaimer: A free society is one where it is safe to be unpopular X-Operating-System: FreeBSD 3.0-CURRENT SMP Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, Mar 01, 1998 at 01:34:07AM -0800, Satoshi Asami wrote: > * > Back out previous commit. MOTIF_STATIC is a user variable (defined by > * > people building packages, i.e., jseger/obrien and me), and is not > * > for ports Makefile's uses. > * > * Ok, sorry ! > > No problem, everybody makes mistakes. (Especially those like you who > do a lot of work. :) I started a new job in ISP business last month. Currently I have lots of things to do ;-) > By the way, I really wish there is some way we could distinguish > between user variables (env. vars or /etc/make.conf) and ports > Makefile variables from bsd.port.mk and warn the porter if he > overstepped his bounds. > > The only way I can think of it is to include bsd.port.mk twice from > each Makefile, and that's just plain ugly. (Maybe we can add it to > portlint....) And including this huge macro file might be an impact in performance ... or ? Think of make release and such ... -- Andreas Klemm powered by ,,symmetric multiprocessor FreeBSD'' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message