From owner-cvs-all Thu Mar 6 13:55:24 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56BDE37B401; Thu, 6 Mar 2003 13:55:21 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75A5543F3F; Thu, 6 Mar 2003 13:55:17 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) by whale.sunbay.crimea.ua (8.12.8/8.12.8/Sunbay) with ESMTP id h26Lt8UC096314 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 6 Mar 2003 23:55:13 +0200 (EET) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.8/8.12.8/Submit) id h26Lt8WR096309; Thu, 6 Mar 2003 23:55:08 +0200 (EET) (envelope-from ru) Date: Thu, 6 Mar 2003 23:55:08 +0200 From: Ruslan Ermilov To: "David O'Brien" Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/less Makefile lesspipe.sh Message-ID: <20030306215508.GA95318@sunbay.com> References: <200303060435.h264Zmkk039395@repoman.freebsd.org> <20030306154915.GE55489@sunbay.com> <20030306181137.GB40027@dragon.nuxi.com> <20030306185824.GE78034@sunbay.com> <20030306200858.GA41375@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20030306200858.GA41375@dragon.nuxi.com> User-Agent: Mutt/1.5.3i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 06, 2003 at 12:08:58PM -0800, David O'Brien wrote: [...] >=20 > > In any case, it's not _stupid_, as the default behavior of > > SCRIPTSNAME of stripping extensions fits 99% of cases, and > > it was designed bearing this in mind. >=20 > Huh?? SCRIPTSNAME is only used when you need to over ride the default > behavior. Perhaps you are talking about "SCRIPTS". What I think is > stupid is that if I do use SCRIPTSNAME I still have to use SCRIPTS. Also > as written, bsd.prog.mk doesn't handle this well: >=20 > .for script in ${SCRIPTS} > .if defined(SCRIPTSNAME) > SCRIPTSNAME_${script:T}?=3D ${SCRIPTSNAME} > .else > SCRIPTSNAME_${script:T}?=3D ${script:T:R} > .endif >=20 > So what we have is SCRIPTS is a list, but SCRIPTSNAME name isn't. > So what happens with > ... > SCRIPTS=3Dfoo.sh bar.sh > SCRIPTSNAME=3Dbaz > .include >=20 > both get installed as baz. SCRIPTS and SCRIPTSNAME should be treated > separately. I'd fix it, but anytime I touch bsd.*.mk you pop up and I > have a federal case on my hands -- thus I now try hard to never touch > them. >=20 What you wrote is an abuse. There are two intended usages: 1. SCRIPTS is single-value. Then you use SCRIPTSNAME. 2. SCRIPTS is multi-value. Then you use SCRIPTSNAME_