From owner-freebsd-mips@FreeBSD.ORG Mon Mar 15 14:40:07 2010 Return-Path: Delivered-To: mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4ECC2106564A for ; Mon, 15 Mar 2010 14:40:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 0B7FC8FC18 for ; Mon, 15 Mar 2010 14:40:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o2FETLjf008630; Mon, 15 Mar 2010 08:29:21 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 15 Mar 2010 08:29:32 -0600 (MDT) Message-Id: <20100315.082932.635883863650633831.imp@bsdimp.com> To: ganbold@gmail.com From: "M. Warner Losh" In-Reply-To: <4B9E34AE.9060301@gmail.com> References: <20100314.181902.67053632336017068.imp@bsdimp.com> <4B9E34AE.9060301@gmail.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mips@FreeBSD.org Subject: Re: Request for review: AR71XX config cleanup X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2010 14:40:07 -0000 In message: <4B9E34AE.9060301@gmail.com> Ganbold writes: : M. Warner Losh wrote: : > Greetings, : > : > I've done a quick stab at cleaning up the AR71XX config file. The : > problem with it is that isn't for the AR71XX, but really for the : > RouterStation Pro for Ubiquiti. Every time I build my normal : > ROUTER-STATION board, I forget to put the hints back and it won't : > boot. : > : > So, I've created a std.ar71xx. This is the standard config file for : > all ar71xx boards. You can then specialize it to reflect the : > population of your specific board. I've also separated the hints that : > are relevant to the Atheros SoC from those that are relevant only to a : > specific board. There's a std.ar71xx.hints. : > : > The patches for this are at : > http://people.freebsd.org/~imp/ar71xx-config.diff to illustrate all : > the details. : > : > In general, I think this looks like a good design pattern for phasing : > out DEFAULTS on the other architectures as well. But before I expand : > it to them, I'd like to get the mipsy world hammered out. : > : > Comments? : > : : Maybe it is not that important, but I see some naming differences in : filenames and in comments like ROUTER-STATION, RouterStation, : ROUTERSTATION, RSPRO etc. : Maybe it can be RouterStation in comments and RS and RSPRO as config : filenames. : Please ignore if I'm wrong here. I thought RS was too short, and ROUTERSTATIONPRO to be too long. I should also find the official capitialization. It is ROUTER-STATION on the actual board. Warner