From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 11:44:08 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 0E6031065673; Thu, 15 Jan 2009 11:44:08 +0000 (UTC) Date: Thu, 15 Jan 2009 11:44:08 +0000 From: Alexey Dokuchaev To: "M. Warner Losh" Message-ID: <20090115114407.GA67726@FreeBSD.org> References: <200901142232.n0EMWhGw055895@svn.freebsd.org> <20090115020752.52566769.stas@FreeBSD.org> <20090114.190527.1058804377.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20090114.190527.1058804377.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i Cc: stas@FreeBSD.org, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, gonzo@FreeBSD.org Subject: Re: svn commit: r187251 - head/sys/mips/malta X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2009 11:44:08 -0000 On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote: > In message: <20090115020752.52566769.stas@FreeBSD.org> > Stanislav Sedov writes: > : > + shift = 8 * (reg & 3); > : > > : > : Would it make sense to replace this with > : > + shift = (reg & 3) << 3; > : > : to not rely on possible compiler optimizations? > > I don't think that it matters all that much these days... But the name "shift" kinda suggests << instead of *, no? ./danfe