From owner-freebsd-ipfw@FreeBSD.ORG  Tue Sep 19 08:48:59 2006
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
X-Original-To: freebsd-ipfw@FreeBSD.org
Delivered-To: freebsd-ipfw@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 74DD216A415
	for <freebsd-ipfw@FreeBSD.org>; Tue, 19 Sep 2006 08:48:59 +0000 (UTC)
	(envelope-from novel@FreeBSD.org)
Received: from novel.fannet.ru (novel.fannet.ru [82.116.56.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A560243D49
	for <freebsd-ipfw@FreeBSD.org>; Tue, 19 Sep 2006 08:48:58 +0000 (GMT)
	(envelope-from novel@FreeBSD.org)
Received: from novel.fannet.ru (localhost [127.0.0.1])
	by novel.fannet.ru (8.13.8/8.13.6) with ESMTP id k8J8nCrw026165;
	Tue, 19 Sep 2006 12:49:12 +0400 (MSD)
	(envelope-from novel@FreeBSD.org)
Received: (from novel@localhost)
	by novel.fannet.ru (8.13.8/8.13.6/Submit) id k8J8nBPP026164;
	Tue, 19 Sep 2006 12:49:11 +0400 (MSD)
	(envelope-from novel@FreeBSD.org)
X-Authentication-Warning: novel.fannet.ru: novel set sender to
	novel@FreeBSD.org using -f
Date: Tue, 19 Sep 2006 12:49:11 +0400
From: Roman Bogorodskiy <novel@FreeBSD.org>
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
Message-ID: <20060919084207.GD93854@novel.fannet.ru>
References: <20060918125848.GB93854@novel.fannet.ru>
	<450F6F6D.6020105@yandex.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="84ND8YJRMFlzkrP4"
Content-Disposition: inline
In-Reply-To: <450F6F6D.6020105@yandex.ru>
X-PGP: http://people.freebsd.org/~novel/novel.key.asc
Cc: freebsd-ipfw@FreeBSD.org
Subject: Re: A bit weird code
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2006 08:48:59 -0000


--84ND8YJRMFlzkrP4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

  Andrey V. Elsukov wrote:

> Roman Bogorodskiy wrote:
> >I was reading ipfw sources and spotted such line (sbin/ipfw/ipfw2.c,
> >line 4871):
> >
> >err(EX_UNAVAILABLE, "getsockopt(%s)", "IP_FW_ADD");
> >
> >And it's there since 1.1 revision of this file. I wonder it has some
> >sacred meaning or just a typo.
>=20
> I don't see this code at this line :)
> If you mean this code:
>     if (do_cmd(IP_FW_ADD, rule, (uintptr_t)&i) =3D=3D -1)
>         err(EX_UNAVAILABLE, "getsockopt(%s)", "IP_FW_ADD");
>=20
> I think this is "copy&paste" bug :)

Yeah, my fault, it's actually on line 4829, rev. 1.98.

--84ND8YJRMFlzkrP4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iQCVAwUBRQ+vB4B0WzgdqspGAQKg/gP/T6ZHHVUKeXfMWPxSbAIMs92rq5AXgDSU
aHhaseKQmdNG5NVZI2dqNz+odw8g7lRdq83Wr93ZyLYbZ78QYt4tfWnqLRfhoi+E
QkGHcvvIehFm6oYqtpyqxiKXVnnhaB8nPgj/AMeFiy2CozwdlRlw6gawkOzOsfGr
Hd9RXmvpJqQ=
=AQ0J
-----END PGP SIGNATURE-----

--84ND8YJRMFlzkrP4--