From owner-freebsd-net@FreeBSD.ORG  Fri Nov 18 23:35:06 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C7FA106564A;
	Fri, 18 Nov 2011 23:35:06 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 18DCE8FC0A;
	Fri, 18 Nov 2011 23:35:05 +0000 (UTC)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id
	pAINZ4Jr030006; Sat, 19 Nov 2011 00:35:04 +0100 (CET)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.4/8.14.4/Submit) id pAINZ416030005;
	Sat, 19 Nov 2011 00:35:04 +0100 (CET) (envelope-from marius)
Date: Sat, 19 Nov 2011 00:35:04 +0100
From: Marius Strobl <marius@alchemy.franken.de>
To: Ben Hutchings <bhutchings@solarflare.com>
Message-ID: <20111118233504.GK93221@alchemy.franken.de>
References: <1321652051.2883.76.camel@bwh-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1321652051.2883.76.camel@bwh-desktop>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net@freebsd.org, Philip Paeps <philip@freebsd.org>
Subject: Re: sfxge: Remove interrupt self-test code
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2011 23:35:06 -0000

On Fri, Nov 18, 2011 at 09:34:11PM +0000, Ben Hutchings wrote:
> sfxge: Remove interrupt self-test code
> 
> It's not currently used; it didn't build on 32-bit and the previous
> build fix is incorrect.  If we really implement self-tests we can do
> this again properly.

Yes, I've also already noticed that this part of r227640 wasn't quite
correct. However Philip suggested to just leave it in for now until
we figure out what on earth the code actually is supposed to do and as
the atomic_cmpset_ptr(9) also works on LP64 and isn't more broken than
the atomic_cmpset_long(9) that was in there before (actually this should
have been atomic_cmpset_64(9) for an uint64_t, which isn't necessarily
available on ILP32 including i386 though). Probably this should have
been converted to be of type cpuset_t and to use the accessors from           
<sys/cpuset.h> as nowadays we also support more than 64 CPUs. I'm also
fine with just nuking the interrupt self-test altogether though.

Marius