From owner-svn-src-head@FreeBSD.ORG Sat Jun 20 15:15:22 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4CFB825F; Sat, 20 Jun 2015 15:15:22 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x229.google.com (mail-ob0-x229.google.com [IPv6:2607:f8b0:4003:c01::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F11D894; Sat, 20 Jun 2015 15:15:22 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obbsn1 with SMTP id sn1so90574905obb.1; Sat, 20 Jun 2015 08:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=t9J3lywQLbKCNh/QvBVezqUjjbffNc5yPR2RGwl7yGg=; b=OWH7qsNzyBJR7o+pWr8fmsEl4caLQTxWDD4KSnxBzndrhahHwWDr+3dBnggqpc1kay hEXegZuYYltpxn4YlvnTQVdWcvo2bPHWpooR/5IEceKDN4CK3hMxpYAmRKBey3KN7DRf 4Ang9pq58MkSQ5HGJUwzVPnt8BM2cyKzYgptgNXDl2jjtqCIx6SWtyES0xTYsOeYBSkV Hzxu4AEbAEj05ClgYgG2RWGtyyPf0+h4qcXnT+oyIYWzd3Exi9iz/ierLp3XEIyI2ZGz 4KtuJGNd6vj96H/XxRc8xu03cA0wiijeWY9Kxr11f5jOVIzRvEbP0O2pe8xDcH3Xr2d5 EBhg== MIME-Version: 1.0 X-Received: by 10.202.190.134 with SMTP id o128mr17132897oif.111.1434813321456; Sat, 20 Jun 2015 08:15:21 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Sat, 20 Jun 2015 08:15:21 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Sat, 20 Jun 2015 08:15:21 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <5585820C.4000209@freebsd.org> References: <201506201503.t5KF33Km091795@svn.freebsd.org> <5585820C.4000209@freebsd.org> Date: Sat, 20 Jun 2015 23:15:21 +0800 Message-ID: Subject: Re: svn commit: r284644 - head/usr.sbin/fstyp From: Marcelo Araujo To: Allan Jude Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, Benjamin Kaduk , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 15:15:22 -0000 You should fix and upstream, I just did that last week. On Jun 20, 2015 11:08 PM, "Allan Jude" wrote: > On 2015-06-20 11:05, Benjamin Kaduk wrote: > > On Sat, Jun 20, 2015 at 11:03 AM, Allan Jude > > wrote: > > > > Author: allanjude (doc committer) > > Date: Sat Jun 20 15:03:02 2015 > > New Revision: 284644 > > URL: https://svnweb.freebsd.org/changeset/base/284644 > > > > Log: > > Fix the build for gcc by lowering the WARNS level > > > > > > Are the warnings emitted by gcc posted somewhere so that I can convince > > myself dropping WARNS is better than changing the code to work around > them? > > > > -Ben > > The warnings come from the ZFS contrib code, so I was under the > impression we didn't want to fix those and diverge form upstream. > > via kib on irc: > > ===> usr.sbin/fstyp (all) > cc1: warnings being treated as errors > In file included from > /scratch/tmp/kib/src/usr.sbin/fstyp/../../sys/cddl/contrib > from /scratch/tmp/kib/src/usr.sbin/fstyp/zfs.c:41: > n/fs/zfs/sys/dmu.h:638: warning: function declaration isn't a prototype > n/fs/zfs/sys/dmu.h:639: warning: function declaration isn't a prototype > > -- > Allan Jude > >