From owner-freebsd-current@FreeBSD.ORG  Wed Feb 11 02:43:15 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C54376AE
 for <freebsd-current@freebsd.org>; Wed, 11 Feb 2015 02:43:15 +0000 (UTC)
Received: from mail-la0-f49.google.com (mail-la0-f49.google.com
 [209.85.215.49])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5090EFFD
 for <freebsd-current@freebsd.org>; Wed, 11 Feb 2015 02:43:14 +0000 (UTC)
Received: by labgm9 with SMTP id gm9so773330lab.2
 for <freebsd-current@freebsd.org>; Tue, 10 Feb 2015 18:43:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:date:message-id:subject:from:to:content-type;
 bh=U3Ww4uTNHjn+xNuS9HHFN8AvXe4l7lgFD8Myd+W7SvM=;
 b=eh13R9CsBCGczdKqX4AHQsfeDIZ64YOfIW6VGrMNsrF5ey6hSfu02vMTqIvQbBlJjX
 3IuJDjcnOWWZ7aQuIowLKApz3k+q5VbjR6K10fVjk2gC22zR40bv8/kEK/XckZ0yDp0O
 a+m8Az7fTZDlJ5zN0VG+H1n6b9NEqOaIh5dl65J+KxalR524TloC4lMbNOMxszMstbLM
 1UMIY3DRRNZTOz5mfJbxKuEqD9Jd3rX0CEc2ZiGzNLYXKyp0+aanZtCWaipY/TbaBrOq
 w352HERlz/FS4J4hFOLG9yfeOD0Bz9hBuTQnMLNYi1lABqOUttI09Xo4b+sJxZfwC9Sb
 4fow==
MIME-Version: 1.0
X-Received: by 10.152.115.139 with SMTP id jo11mr25708595lab.24.1423622586549; 
 Tue, 10 Feb 2015 18:43:06 -0800 (PST)
Received: by 10.112.98.136 with HTTP; Tue, 10 Feb 2015 18:43:06 -0800 (PST)
Date: Tue, 10 Feb 2015 18:43:06 -0800
Message-ID: <CAPx1Gvf8v1q2JkmzYF9ryoPk=XKYTiUG7gnu5TDXGn_7kqLd+Q@mail.gmail.com>
Subject: LOCAL_MTREE vs DB_FROM_SRC
From: Chris Torek <chris.torek@gmail.com>
To: freebsd-current <freebsd-current@freebsd.org>
X-Mailman-Approved-At: Wed, 11 Feb 2015 03:29:18 +0000
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 02:43:15 -0000

(Apologies for google mail, I moved a while back and my office at home is
still not up and hence my regular FreeBSD machine at home is also not up.)

In Makefile.inc1 we have:

.if defined(DB_FROM_SRC)
INSTALLFLAGS+= -N ${.CURDIR}/etc
MTREEFLAGS+= -N ${.CURDIR}/etc
.endif

which is fine as far as it goes, but then if ${LOCAL_MTREE} is defined we
have this:

.for _mtree in ${LOCAL_MTREE}
        mtree -deU -f ${.CURDIR}/${_mtree} -p ${WORLDTMP} > /dev/null
.endfor

which omits the -N flag, even with DB_FROM_SRC set.  This means if a local
mtree file "wants" user and/or group names that are not on your build
system, but are in the new (but not yet installed anywhere) master.passwd
and/or group files, the build fails when prepping the worldtmp area.  Seems
like this should be "mtree ${MTREEFLAGS} ...", shouldn't it?

Chris