Date: Tue, 2 Jul 2019 07:39:01 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Mark Linimon <linimon@lonesome.com>, Alexey Dokuchaev <danfe@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504198 - head/Mk Message-ID: <20190702053901.GA16913@ThinkPad-X200.g.anongoth.pl> In-Reply-To: <alpine.LSU.2.21.1907020017480.4639@anthias.pfeifer.com> References: <201906141610.x5EGAdnN049103@repo.freebsd.org> <F69E23F2-E526-4B3F-95EB-1786222C2D61@cschubert.com> <20190614165425.GA42674@FreeBSD.org> <8BDC3B40-7FEA-46EA-AE7C-A3C266F6978F@cschubert.com> <20190614175822.GA3336@FreeBSD.org> <20190615061345.GA20346@lonesome.com> <alpine.LSU.2.21.1906151028570.3441@anthias.pfeifer.com> <20190615173659.GB19307@lonesome.com> <alpine.LSU.2.21.1907020017480.4639@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--2Gs4v54bG6iWa2iQ Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Forcing ports GCC everywhere would be a nice change to support stable branc= hes, but it would probably also undercover some bugs in many ports (that's = why I focused on adding USES manually). s/USE_GCC=3Dany/USE_GCC=3Dyes/g IMO is definitely ok to commit. On 19-07-02 00:23:47, Gerald Pfeifer wrote: >On Sat, 15 Jun 2019, Mark Linimon wrote: >> No, our build cluster is still using base 4.2 by default. Most of >> the ports that fail are fixed by specifying a USES that names a newer >> compiler. > >Yep, such as the one below. Hence my proposal to switch to a >newer version of GCC by default where there's currently USE_GCC=3Dany >or similar via USES=3Dcompiler. > >> Clang is "coming soon". It's a race between the folks working >> on fixing ports on base vs. the folks working on clang :-) > >Well, and it surely is going to be an easier switch from current >GCC (such as GCC 8) to current clang than from a decade old compiler >(such as GCC 4.2). > >I'm not necessarily proposing to use modern GCC across the port, but >at least where some version of GCC is explicitly requested (hence >s/USE_GCC=3Dany/USE_GCC=3Dyes/g and, though that can be an independent >change, the equivalent in Mk/Uses/compiler.mk). > >Gerald > > >=3D=3D=3D=3D=3D=3D=3D=3D example commit =3D=3D=3D=3D=3D=3D=3D=3D >Author: stephen >Date: Sun Jun 30 23:32:57 2019 >New Revision: 505525 >URL: https://svnweb.freebsd.org/changeset/ports/505525 > >Log: > - On GCC architectures, don't use the base GCC to build. > > PR: 238885 > Submitted by: Piotr Kubaj <pkubaj@FreeBSD.org> > >Modified: > head/math/octave-forge-nurbs/Makefile > >Modified: head/math/octave-forge-nurbs/Makefile >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/math/octave-forge-nurbs/Makefile Sun Jun 30 23:10:19 2019 (r50552= 4) >+++ head/math/octave-forge-nurbs/Makefile Sun Jun 30 23:32:57 2019 (r50552= 5) >@@ -22,8 +22,15 @@ WRKSRC=3D ${WRKDIR}/${OCTSRC}/src > > .include "${.CURDIR}/../../Mk/bsd.octave.mk" > >+.include <bsd.port.pre.mk> >+ >+# Force newer GCC on platforms using GCC 4.2 as base >+.if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc >+USE_GCC=3D yes >+.endif >+ > post-build: > ${RM} ${WRKSRC}/Makefile ${WRKSRC}/configure > cd ${WRKDIR} && ${TAR} cfz ${DISTNAME}.tar.gz ${OCTSRC} > >-.include <bsd.port.mk> >+.include <bsd.port.post.mk> > > >--=20 >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. > --2Gs4v54bG6iWa2iQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl0a7fVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM5 Q0M4ODc4RDkyNDgyODg3M0IyOEEyQjdBNTk5Qjg1MjA4MzlDOUQACgkQelmbhSCD nJ0XohAAxb6bJymZGcLe7OI0bBc1w1fz8fvHTkUUN0//5gJ9prqxd9g7XZWbsudI ARnRfLUm33kfw8gkJVFN/G5mybu9MnuDGS9A4uQmU0K3y/HDJf4XrJgZ4dSAb/BU Q0LwnsSAfHu5B88a4wLx2gFiZt1M+xd7u/hM9PARVNBmrx3JLB9rcgKmahyPLe/f cnidXzc79xnYFVi1OGxTwmwMGjmtyFWCi/oUj6zcyQnh0EP74j9uyTdkD5TJbv90 H5OFRK7fVnHvNzVCU6Fd9qHqtnzORderlFCuitMP0yjFV6SAmdk4LQRC3TUHXECn mI7CtHYWmCBZSs70Iw3HHH5GVP5QtG6bKiZ3il4gVdFRWQEI0JqEWpEjsxYwhlUr WXwBvjjrGYkKe8OM0RuZCeApyB0sGFFjt6erBpMq9OSpF7vkH9KwuPGfx/uld6Et 3kVXEXCoT/0lSPPUc/lt3bgiGfM40rcz1DiYmNSZyrA0yi6eSSQErwR31gx/qZ7/ E/JADE7W45sjpNhCCSlyz7x1PjRpj2BR7Bd7J8Ou12253Xp1O0gf3bUWsrIhiMmm 98Do9b+YP/YQ6K005aDAbAPSKS5/2pT03hdC9Y7hXYVhtJyOptKi18elLcGhcSAD cb4eiKFolsSQtX6SR3nA1KaUbGpssboC/2dB0QYqWwtcgamLEyw= =8sjZ -----END PGP SIGNATURE----- --2Gs4v54bG6iWa2iQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190702053901.GA16913>