From owner-svn-src-all@FreeBSD.ORG Fri Nov 16 16:05:44 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FAF331E; Fri, 16 Nov 2012 16:05:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id B64AB8FC16; Fri, 16 Nov 2012 16:05:43 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qAGG5eBS098445; Fri, 16 Nov 2012 18:05:40 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qAGG5eBS098445 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qAGG5dF6098444; Fri, 16 Nov 2012 18:05:40 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 16 Nov 2012 18:05:39 +0200 From: Konstantin Belousov To: mdf@FreeBSD.org Subject: Re: svn commit: r243134 - head/sys/sys Message-ID: <20121116160539.GN73505@kib.kiev.ua> References: <201211160625.qAG6PLd2032062@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sG3ZcHdzWW76U2Qm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 16:05:44 -0000 --sG3ZcHdzWW76U2Qm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 16, 2012 at 08:02:39AM -0800, mdf@FreeBSD.org wrote: > On Thu, Nov 15, 2012 at 10:25 PM, Konstantin Belousov w= rote: > > Author: kib > > Date: Fri Nov 16 06:25:20 2012 > > New Revision: 243134 > > URL: http://svnweb.freebsd.org/changeset/base/243134 > > > > Log: > > Alphabetically reorder the forward-declarations of the structures. > > Add the declaration for enum idtype, to be used later. >=20 > Forward declarations of enums isn't an ISO C feature, but a gcc > extension. While the kernel uses many gcc extensions, it hides most > under a #define so unsupported compilers can continue along. This > unsupported feature can't be hidden. >=20 > Does the forward declaration prevent another warning? It allows to prevent the namespace pollution from sys/wait.h idtype_t, need= ed due to the kern_wait6() declaration. --sG3ZcHdzWW76U2Qm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCmZFMACgkQC3+MBN1Mb4hItACfYuqhdfALdxSbitgA0I9NDXFn 5EYAnA+am6ZfjA6AAg50rYDQoNzMlNw4 =LJWv -----END PGP SIGNATURE----- --sG3ZcHdzWW76U2Qm--