From owner-svn-src-projects@FreeBSD.ORG Fri Aug 2 14:39:14 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B4749C03; Fri, 2 Aug 2013 14:39:14 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-we0-x229.google.com (mail-we0-x229.google.com [IPv6:2a00:1450:400c:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F19DA2A09; Fri, 2 Aug 2013 14:39:13 +0000 (UTC) Received: by mail-we0-f169.google.com with SMTP id n5so598038wev.14 for ; Fri, 02 Aug 2013 07:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=wOt4Xrr0If3nPMqFISKXvmcUQB3T3dzyzLMgstKhJio=; b=JlXOnjOlsYa00O/nbUBBR8Xdzo1IyfxWUkMpg6CHv10I/f/a1yVSR6PBOUYUvnKfyN 5td1lImjsx4AItGzHRDiveziY9gNHaoCanB4IpNiQrmkYFbabXpbVIzUmBSsdJH65c6M AjoG1cFa5yGncBRc+KBpeU4yXCmknf2pjpis6fHeBLkLSK0b/I6QSYgwODKFpHXtIfy+ 4P4E6teW7q02z1RkOnq8jYNR1yITsqzJNu8w5zK4wrT4peSSVQJeofJ1SDb3/fy3Xa1x NSeB9KFkYDYT090fKH7kDU8fxAStpB4LBoEY9gA5eh1wwVXfl1FqftOXAzb7Wv5N57Ol UHsA== MIME-Version: 1.0 X-Received: by 10.180.149.134 with SMTP id ua6mr2081868wib.51.1375454352187; Fri, 02 Aug 2013 07:39:12 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.217.142.76 with HTTP; Fri, 2 Aug 2013 07:39:12 -0700 (PDT) In-Reply-To: <201308020020.r720K5Gu099845@svn.freebsd.org> References: <201308020020.r720K5Gu099845@svn.freebsd.org> Date: Fri, 2 Aug 2013 16:39:12 +0200 X-Google-Sender-Auth: u2RmR-mhOBJJNWwPmCm3oM1WHrQ Message-ID: Subject: Re: svn commit: r253877 - in projects/atomic64/sys: amd64/include i386/include From: Attilio Rao To: Jung-uk Kim Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Aug 2013 14:39:14 -0000 On Fri, Aug 2, 2013 at 2:20 AM, Jung-uk Kim wrote: > Author: jkim > Date: Fri Aug 2 00:20:04 2013 > New Revision: 253877 > URL: http://svnweb.freebsd.org/changeset/base/253877 > > Log: > Reimplement atomic operations on PDEs and PTEs in pmap.h. This change > significantly reduces duplicate code. Also, it may improve and even correct > some questionable implementations. I think this is not the right way to do it, in particular the loadstore part. What you should do is to implement atomic_readandclear_* with an atomic_readandset_* (so taking a parameter as a set value) and then use atomic_readandset_*() for PTE operations. Attilio -- Peace can only be achieved by understanding - A. Einstein