From owner-cvs-all@FreeBSD.ORG Sat Feb 2 20:50:31 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 327AF16A418; Sat, 2 Feb 2008 20:50:31 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.130]) by mx1.freebsd.org (Postfix) with ESMTP id AA4EB13C448; Sat, 2 Feb 2008 20:50:30 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.1/8.14.1) with ESMTP id m12KBrih061319; Sat, 2 Feb 2008 23:11:53 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.1/8.14.1/Submit) id m12KBrd9061318; Sat, 2 Feb 2008 23:11:53 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 2 Feb 2008 23:11:53 +0300 From: Gleb Smirnoff To: Alexander Motin Message-ID: <20080202201153.GL14339@FreeBSD.org> References: <200801271501.m0RF1Hki089075@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200801271501.m0RF1Hki089075@repoman.freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Louis Mamakos , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 20:50:31 -0000 Alexander, you should have asked me for review before committing! This is not a bug, this is a feature. This was quite clear from the comments, that you removed: - /* if export hook disconnected stop running expire(). */ This is intended behavior. We must not lose information unless user explicitly wants to lose information. In the latter case he will connect ng_hole(4) node to the "export" hook. But we must not lose information if user runs some script that swaps receiving node on the "export" hook. Please backout this change! I'm sorry that have seen it only after it hit RELENG_6 and RELENG_7 :( But that's your fault that you haven't asked me for review. P.S. I'm closing the PR. On Sun, Jan 27, 2008 at 03:01:16PM +0000, Alexander Motin wrote: A> mav 2008-01-27 15:01:16 UTC A> A> FreeBSD src repository A> A> Modified files: A> sys/netgraph/netflow ng_netflow.c A> Log: A> Run expire even without export hook connected. A> A> PR: kern/119839 A> A> Revision Changes Path A> 1.15 +4 -8 src/sys/netgraph/netflow/ng_netflow.c A> _______________________________________________ A> cvs-all@freebsd.org mailing list A> http://lists.freebsd.org/mailman/listinfo/cvs-all A> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE