From owner-cvs-all@FreeBSD.ORG  Wed Apr 13 09:52:40 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6471A16A4CE; Wed, 13 Apr 2005 09:52:40 +0000 (GMT)
Received: from mail.3wgraphics.com (mail.3wgraphics.com [194.87.91.161])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DAFB343D49; Wed, 13 Apr 2005 09:52:39 +0000 (GMT)
	(envelope-from skv@FreeBSD.org)
Received: from [192.168.0.1] (helo=[192.168.0.1])
	by mail.3wgraphics.com with esmtp id 1DLeY2-000PuI-CD;
	Wed, 13 Apr 2005 13:52:38 +0400
Message-ID: <425CEBE6.3030306@FreeBSD.org>
Date: Wed, 13 Apr 2005 13:52:38 +0400
From: Sergey Skvortsov <skv@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.8a6) Gecko/20050111
X-Accept-Language: en,ru
MIME-Version: 1.0
To: Joe Marcus Clarke <marcus@FreeBSD.org>
References: <200504130320.j3D3Kuw5004935@repoman.freebsd.org>
In-Reply-To: <200504130320.j3D3Kuw5004935@repoman.freebsd.org>
X-Enigmail-Version: 0.90.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/portlint Makefileports/devel/portlint/src
 portlint.pl
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2005 09:52:40 -0000

Joe Marcus Clarke wrote:
>   Modified files:
>     devel/portlint       Makefile 
>     devel/portlint/src   portlint.pl 
>   Log:
>   Update to 2.7.1
>   
>   * Check to make sure only characters [-.a-zA-Z0-9_] appear in file names [1]

As already discussed, this regex is too restrictive.

Just run this:
find /usr/ports -name "patch-*"|grep -v --regexp='patch-[-.a-zA-Z0-9_]*$'

1. Filenames can contain many special symbols (like '+', ','), for example:
benchmarks/bonnie++/files/patch-bonnie++.cpp

You can't cover all possible filenames because they are controlled by 
authors of software.

2. Regex in portlint does not equal to original in "Porters Handbook" 
([.-_a-zA-Z0-9]). The latter still does not fixed.

3. '::' delimiter for directories is legal and more aestetic than ugly '__'.

So, I offer more tolerant regex [-.a-zA-Z0-9_:+].

This useless patch renaming can produce cvsup storm and there is no 
advantages for end-users:

%find /usr/ports -name "patch-*"|grep -v --regexp='patch-[-.a-zA-Z0-9_]*$'|wc -l
4119

Dixi.

-- 
Sergey Skvortsov
mailto: skv@FreeBSD.org