From owner-freebsd-audit  Sun Jun 24 15:12:55 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from iatl0x01.coxmail.com (iatl1x01.coxmail.com [206.157.231.23])
	by hub.freebsd.org (Postfix) with ESMTP id 843C237B405
	for <audit@FreeBSD.org>; Sun, 24 Jun 2001 15:12:52 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2)
          with ESMTP
          id <20010624221251.BZKY1034.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Sun, 24 Jun 2001 18:12:51 -0400
Message-ID: <XFMail.20010624221124.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.4.7 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200106232304.f5NN4Zh89727@coffee.q9media.com>
MYHEADER: test
Date: Sun, 24 Jun 2001 22:11:24 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: Mike Barcroft <mike@q9media.com>
Subject: RE: src/usr.sbin/zic patch
Cc: audit@FreeBSD.org
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG


On 23-Jun-2001 Mike Barcroft wrote:
| I would appreciate it if someone would commit the patch at the end of
| this message.  Also available at:
| http://testbed.q9media.net/freebsd/zic.20010623.patch
...
| 
| Index: zic/private.h
| ===================================================================
| RCS file: /home/ncvs/src/usr.sbin/zic/private.h,v
| retrieving revision 1.4
| diff -u -r1.4 private.h
| --- zic/private.h     2000/11/28 18:18:56     1.4
| +++ zic/private.h     2001/06/23 22:19:53
| @@ -99,7 +99,7 @@
|  void *       irealloc P((void * pointer, int size));
|  void icfree P((char * pointer));
|  void ifree P((char * pointer));
| -char *       scheck P((const char *string, const char *format));
| +const char * scheck P((const char *string, const char *format));

I believe `__const' should be used to not break K&R. Same goes for the
definition.


Mike

-- 
  Mike Heffner         <mheffner@[acm.]vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message