From owner-freebsd-current@freebsd.org Thu Nov 21 04:18:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 579521ACF94 for ; Thu, 21 Nov 2019 04:18:55 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JRC244T6z3KvW; Thu, 21 Nov 2019 04:18:54 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.20] (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 9b8458cb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 21 Nov 2019 04:18:53 +0000 (UTC) Subject: Re: breakage at usr.sbin/jail/Makefile To: Glen Barber Cc: FreeBSD Current References: <0e3dd332-91d7-0aa1-43cb-43528db7c63a@nomadlogic.org> <20191121041317.GL5599@FreeBSD.org> From: Pete Wright Message-ID: <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> Date: Wed, 20 Nov 2019 20:18:52 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191121041317.GL5599@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 47JRC244T6z3KvW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-4.95 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[239.162.243.23.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.65)[ip: (-9.27), ipnet: 174.136.96.0/20(-3.62), asn: 25795(-0.30), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 04:18:55 -0000 On 11/20/19 8:13 PM, Glen Barber wrote: > On Wed, Nov 20, 2019 at 07:57:57PM -0800, Pete Wright wrote: >> Hello, >> looks like some of the recent commits to usr.sbin/jail/Makefile has broken >> CURRENT.  I am getting this error when attempting a buildworld: >> >> ===> usr.sbin/jail (cleandir) >> make[4]: "/usr/home/pete/git/freebsd/usr.sbin/jail/Makefile" line 21: >> Malformed conditional (${LINKER_TYPE} == "bfd" && ${MACHINE} == "riscv") >> make[4]: Fatal errors encountered -- cannot continue >> make[4]: stopped in /usr/home/pete/git/freebsd/usr.sbin/jail >> *** [cleandir_subdir_usr.sbin/jail] Error code 1 >> >> >> here's the code in question: >>  18 # workaround for GNU ld (GNU Binutils) 2.33.1: >>  19 #   relocation truncated to fit: R_RISCV_GPREL_I against `.LANCHOR2' >>  20 # https://bugs.freebsd.org/242109 >>  21 .if ${LINKER_TYPE} == "bfd" && ${MACHINE} == "riscv" >>  22 CFLAGS+=-Wl,--no-relax >>  23 .endif >> >> >> looks like Ed Maste caught this already in the >> https://bugs.freebsd.org/242109 but wanted to flag it here as well in case >> anyone else runs into this in the hopes it saves some debugging time :) >> > Reverted out of frustration in r354935. thanks! the issue seems to be on my amd64 system ${LINKER_TYPE} is not defined.  i was contemplating suggesting updating the .if clause in the Makefile like so: .if defined($LINKER_TYPE}) && ${LINKER_TYPE} == "bfd" && ${MACHINE} == "riscv" it allows things to compile on my end, but i'm not sure this is best way to resolve this issue. -p -- Pete Wright pete@nomadlogic.org @nomadlogicLA