From owner-freebsd-current@freebsd.org Thu Oct 3 23:28:11 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5E571436E3 for ; Thu, 3 Oct 2019 23:28:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670051.outbound.protection.outlook.com [40.107.67.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46kq1j6VwNz4s5n for ; Thu, 3 Oct 2019 23:28:09 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azKq43Wtx8cmQcnTQIZiyPQDBhAZcPIxLdKF/hPujWATFIR5kWY1a0+uz3qQmFT0FF9FxB2fMVsovROE+iZBE8Xlt45kMbmZpNVLpRI0G52M5Rwc5DvJbJCa4YpWg2+/+CkwilbSDcTusWztpgN+LS+v9Z4tluXFnWFMoSloyjWE3IvVMX0ZGPm4BDrZ0BIL5anLYXoV0E84RfFJhcyhQ6+4geH2lK+vW6Cmg3BN7kxhdmQnUMczP11oZ5K52SqcnlmlSF8URaxI/N5zMHzmx9mgAgEZiB35LY9zAECHG7F0HACQtBxKSdcIoes5YE8e6cxst2woweumljhVHn2A7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxOfcmkb4mPxmkUI3/ecc2Sq8nZY8IsmJKFd525WLkw=; b=DIO+64MsPiWqwYhrkIjaTlWozxr3jCLPqQiuUgS8d5cfZF7iRRs9cO1DwiVLWw6MSi41HWDfLLmyMVB9LWTOxqCwMlSBJHPvc7a+b4NnTItzQ4ydfXMq11KPEGudFEwOHAnHby+IBwawKxgy9WkzavGb9Hu2PvEVc00pcgCJuhVuYcya094rU+WB+POVnyM7v1HGCPhedZHu8gWaS2SQnCuCd5AHfg37yJH8YCNgL/noAQO/K9PJwEt9kIj2EFL1oogIxifYHupRQairFSGkbCicbjr8V1N+82WKDzzYZRiLgiZdI4N6EN2nSSXWCizddrioJz5RXIGgWoW4K5SKLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTOPR0101MB1163.CANPRD01.PROD.OUTLOOK.COM (52.132.51.22) by YTOPR0101MB1097.CANPRD01.PROD.OUTLOOK.COM (52.132.50.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 23:28:08 +0000 Received: from YTOPR0101MB1163.CANPRD01.PROD.OUTLOOK.COM ([fe80::157f:eebf:d4d4:451]) by YTOPR0101MB1163.CANPRD01.PROD.OUTLOOK.COM ([fe80::157f:eebf:d4d4:451%4]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 23:28:07 +0000 From: Rick Macklem To: Peter Jeremy , "freebsd-current@FreeBSD.org" Subject: re: Reproducable deadlock in NFS client Thread-Topic: Reproducable deadlock in NFS client Thread-Index: AQHVej91BrHG3ABX8kqtNRMQbCOvFg== Date: Thu, 3 Oct 2019 23:28:07 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a151083-58e9-4be7-7f80-08d74859590b x-ms-traffictypediagnostic: YTOPR0101MB1097: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(366004)(39860400002)(396003)(199004)(189003)(8676002)(786003)(486006)(81166006)(476003)(99286004)(81156014)(8936002)(478600001)(86362001)(74316002)(52536014)(305945005)(14454004)(25786009)(966005)(186003)(102836004)(2501003)(7696005)(6506007)(46003)(256004)(66946007)(5660300002)(6246003)(6306002)(66446008)(64756008)(66556008)(66476007)(316002)(55016002)(9686003)(110136005)(76116006)(33656002)(2906002)(6436002)(229853002)(71200400001)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1097; H:YTOPR0101MB1163.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K+7xmcdFRf6dGURBqP5HK+atme8MqYezMF0zuiMeHakuae6D8dbi6u+wM8MJ8KB1x/hORyolNatZvLZBNjEO1WyCSjfpK5mG5H8OTVXOdtCs1fjVtBPY6SwxOCDfv2uYoyW0bSAOFXEhxXOKoOgdjsfUmrvaVP7fZgq+WMSLRCrv4eAIgpFT/vtH39e2kg2y0vKkaR2uCfgarBpH6UkHlejAU0UZ24YDZakGrLl2UzL4rsv8RFWocOHETL50Xt3Fe1ZAfLjbbNNV4OBnedO3sn1bk902H4m36uxGqtfiTqQGo0VXZXhyDK1BV9D8EeA1Ect70oSYbeykF87Wpj/EIQ5cCZW/J53cogonw+zpeJZZMpn3OLw1z/178NHDs/NQCAYS8c8bh0Vye/uK9mRq8Az2kw1teJHtuxE6bFbO8J+rsM9XekzALF+vrKlbk7DE3ElMf8nBtuaeRNPWwafXTA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 7a151083-58e9-4be7-7f80-08d74859590b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 23:28:07.8809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bIb4VtkO1Est5bj+m2dZTx8+0dmomSI1ueWPg2NtOlPVeYGM5ukyuSBha/CXPvmtK+PF3vQfymT5HLx0wMbcbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1097 X-Rspamd-Queue-Id: 46kq1j6VwNz4s5n X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.51 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.59 / 15.00]; FAKE_REPLY(1.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[51.67.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.29)[ipnet: 40.64.0.0/10(-3.85), asn: 8075(-2.56), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Oct 2019 23:28:11 -0000 Hi Peter,=0A= =0A= You could try a couple of things:=0A= 1 - kib@ just put a patch up on phabricator that reorganizes the handling= =0A= of vnode_pager_setsize().=0A= D21883=0A= (If you could test this patch, that might be the best approach.)=0A= or=0A= 2 - The only differences between the post r352392 code and the older stuff= =0A= is that it calls vnode_pager_setsize() when the size hasn't changed.= =0A= I can't think of why that might cause a problem, but??=0A= I have a patch in phabricator D21814 that doesn't do the=0A= vnode_pager_setsize() call when the size doesn't change.=0A= --> If this patch were to avoid the hang, it could help diagnose the=0A= problem.=0A= The other difference is that it called vnode_pager_setsize() when ther= e=0A= was a small change, but not enough to affect a page boundary. I can't = think=0A= of how this would affect things either, but..=0A= or=0A= If you can't test either of the above patches, you could try reverting both= =0A= r352393 and r352457, which would put things back the way they've been=0A= for years, to see if that works ok.=0A= =0A= Good luck with it, rick=0A= ps: Btw, capturing "procstat -kk" and "ps axHl" would give you/us more info= .=0A= (The "H" on "ps" shows the iod threads.)=0A= If you can drop into the debugger when it is hung as above, you could= =0A= capture the stuff listed here:=0A= https://www.freebsd.org/doc/en_US.ISO8859-1/books/developers-handbook/kerne= ldebug-deadlocks.html=0A= =0A=