From nobody Fri Jun 27 07:38:21 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bT6qK6DkDz60Qqr; Fri, 27 Jun 2025 07:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bT6qK3225z3wm5; Fri, 27 Jun 2025 07:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751009901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6NHBaDPfwPAm8xvIyoUDC09y9+7HlErdrqSXjXkTOso=; b=vpIM6wrcYZOdiRRTz+9eBaSSJokPkg8Z24BnjQtz7dkhJcX+5GN2LxnQqLf1c/i7Vx0qcb nPBw87EXL1P0djNa6HY6OlGe4lBeqSb95LPMlPVjG+sVk2WpUlFbTuNkt/rtHb40whIwxc 0pnk/WZQDzjoXNHDXX4ERpUyjRPwFSzadp2vMs7CKA3p9ni79jT/IM826EWwRuKbF36//C u/VxzcOz0Mbn9KH1Y7Zz8CgLJRyUpQobQmmwsBLzfeEU4cCjcUg3hAr/RNwHD6ZWyohDFe 2dp8CR23UEbDvyra8EDxJLP5GZoN/iDHhI2FlXSTeDHAon6DTl6j+GC7vWngIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751009901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6NHBaDPfwPAm8xvIyoUDC09y9+7HlErdrqSXjXkTOso=; b=kSXWxYdNJif3kFBrJFjqVSPlk5HcXzukV32obTi4kmsSfwM+i9EW92inF1b4ViCFwxiTnI I5NKheeJG2LR9IPRvzJB3Ie5gldu+dfukwZd0u306ryZaQbl/fg5NvCNZtkcG+bYscfhZ8 3eJh12KNUy4tVHNfB63PKuDfkhNmRblRH49RuJplws3pbYpI7pHESi77jvJAPufDHbs/Dd XTwetDHiT2XBfs4fIh+alCIth7DiHcYs5yEXDgguObBlcf7JIhfuMjh9D3vSlucM67mS6i CGWLgJAc5GL+WPHJM3Rv86PAbSaQmIYebnXBxUViEbOsT+xJ7WCA5z5eeh2ogw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751009901; a=rsa-sha256; cv=none; b=sQQo2ahTlXIV4I2huOPU3aAOLCmofb1asv4tki97DaUor8oBHOaYc5Fgu6eRmhOKIj33+C T/4eWqMesJDJwpuMPAmA4CGRII4dJDZoNc3AUkKHWNwzCdXnMoQBYvo0vKhIWG8JE+jMsT iOThMEd8kfBxI9ENHlH9GJ7NnG4LSTPZ6101SbE7pAp+wmBXfubLD+/GTkeiyS1gCnmTe0 fZ9Cm5OVXyZYEuZ1O3LSlyWc8xl8yv9R5M7Gsms+WOE5d7x7V02TxsGiGaRbTeS/qec7Pa TwAamVFmWdjVaHBX+DSi1ZHHQrMtLa8ucN+gr7oj9deKk/uXdA2SxcUXbJs8Yg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bT6qK1z1lzfcd; Fri, 27 Jun 2025 07:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55R7cLCV089587; Fri, 27 Jun 2025 07:38:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55R7cLF6089584; Fri, 27 Jun 2025 07:38:21 GMT (envelope-from git) Date: Fri, 27 Jun 2025 07:38:21 GMT Message-Id: <202506270738.55R7cLF6089584@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: ec88c4841385 - stable/14 - ns8250: use LSR_THRE instead of LSR_TEMT for checking tx flush List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ec88c48413850768692a92736229e85b5d262935 Auto-Submitted: auto-generated The branch stable/14 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=ec88c48413850768692a92736229e85b5d262935 commit ec88c48413850768692a92736229e85b5d262935 Author: Andriy Gapon AuthorDate: 2024-11-10 11:15:30 +0000 Commit: Andriy Gapon CommitDate: 2025-06-27 07:37:55 +0000 ns8250: use LSR_THRE instead of LSR_TEMT for checking tx flush LSR_TEMT bit is set if both transmit hold and shift registers are empty, but the flush command flushes only the hold register. While here, update the diagnostic message to report which registers could not be flushed. (cherry picked from commit 0d2fd5b99c95329085d0700a4dd38507a054a50d) --- sys/dev/uart/uart_dev_ns8250.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/uart/uart_dev_ns8250.c b/sys/dev/uart/uart_dev_ns8250.c index ced3b44b5749..b73838b7d2b2 100644 --- a/sys/dev/uart/uart_dev_ns8250.c +++ b/sys/dev/uart/uart_dev_ns8250.c @@ -230,12 +230,12 @@ ns8250_flush(struct uart_bas *bas, int what) * https://github.com/rust-vmm/vm-superio/issues/83 */ lsr = uart_getreg(bas, REG_LSR); - if (((lsr & LSR_TEMT) == 0) && (what & UART_FLUSH_TRANSMITTER)) + if (((lsr & LSR_THRE) == 0) && (what & UART_FLUSH_TRANSMITTER)) drain |= UART_DRAIN_TRANSMITTER; if ((lsr & LSR_RXRDY) && (what & UART_FLUSH_RECEIVER)) drain |= UART_DRAIN_RECEIVER; if (drain != 0) { - printf("ns8250: UART FCR is broken\n"); + printf("ns8250: UART FCR is broken (%#x)\n", drain); ns8250_drain(bas, drain); } }