Date: Wed, 24 Oct 2018 15:29:15 +0200 From: Tobias Kortkamp <tobik@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r482903 - head/chinese/fcitx-libpinyin Message-ID: <1540387755.2428664.1553012856.09F07AB9@webmail.messagingengine.com> In-Reply-To: <201810241148.w9OBmdaA018563@repo.freebsd.org> References: <201810241148.w9OBmdaA018563@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 24, 2018, at 13:48, Wen Heping wrote: > Author: wen > Date: Wed Oct 24 11:48:38 2018 > New Revision: 482903 > URL: https://svnweb.freebsd.org/changeset/ports/482903 > > Log: > - Update to 0.5.3 > > PR: 231616 > Submitted by: ryo@tetera.org > Approved by: maintainer > > Modified: > head/chinese/fcitx-libpinyin/Makefile > head/chinese/fcitx-libpinyin/distinfo > head/chinese/fcitx-libpinyin/pkg-plist > > Modified: head/chinese/fcitx-libpinyin/Makefile > ============================================================================== > --- head/chinese/fcitx-libpinyin/Makefile Wed Oct 24 11:47:28 2018 (r482902) > +++ head/chinese/fcitx-libpinyin/Makefile Wed Oct 24 11:48:38 2018 (r482903) > @@ -2,7 +2,7 @@ > # $FreeBSD$ > > PORTNAME= fcitx-libpinyin > -PORTVERSION= 0.3.2 > +PORTVERSION= 0.5.3 > CATEGORIES= chinese > MASTER_SITES= http://download.fcitx-im.org/${PORTNAME}/:body \ > http://download.fcitx-im.org/data/:data > @@ -16,28 +16,30 @@ COMMENT= Libpinyin support for Fcitx > > LICENSE= GPLv2 > > +BUILD_DEPENDS= bash:shells/bash > LIB_DEPENDS= libfcitx-config.so:chinese/fcitx \ > - libpinyin.so:chinese/libpinyin > + libpinyin.so:chinese/libpinyin\ > + libFcitxQt5WidgetsAddons.so:textproc/fcitx-qt5 > > USES= tar:xz cmake gettext pkgconfig > INSTALLS_ICONS= yes > > -_MODEL_VER= 20130308 > +_MODEL_VER= 20161206 > > -OPTIONS_DEFINE= QT4 > -OPTIONS_DEFAULT=QT4 > -QT4_DESC= Enable Qt4 for dictmanager > +OPTIONS_DEFINE= QT5 > +OPTIONS_DEFAULT=QT5 > +QT5_DESC= Enable Qtr for dictmanager > > .include <bsd.port.options.mk> > > -.if ${PORT_OPTIONS:MQT4} > -USES+= qt:4 > -USE_QT= qmake_build moc_build rcc_build uic_build gui webkit > +.if ${PORT_OPTIONS:MQT5} > +USES+= qt:5 > +USE_QT= qmake_build gui webengine webkit buildtools > USE_LDCONFIG= ${PREFIX}/lib/fcitx/qt - Why not use options helpers here? - Are you sure that qt5-buildtools is a run dependency or was buildtools_build meant here? - It is unusual for a port to depend on both qt5-webengine and qt5-webkit. I find no reference to webkit in the sources. Can you recheck Poudriere logs if it really links with libQt5WebKit?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1540387755.2428664.1553012856.09F07AB9>