From owner-freebsd-audit Fri Oct 4 8:35:15 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 060FE37B43D for ; Fri, 4 Oct 2002 08:35:07 -0700 (PDT) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 940E143E65 for ; Fri, 4 Oct 2002 08:35:05 -0700 (PDT) (envelope-from keramida@freebsd.org) Received: from hades.hell.gr (patr530-a120.otenet.gr [212.205.215.120]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id g94FZ16T000169 for ; Fri, 4 Oct 2002 18:35:02 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.6/8.12.6) with ESMTP id g94FZ2em009708 for ; Fri, 4 Oct 2002 18:35:03 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by hades.hell.gr (8.12.6/8.12.6/Submit) id g94ElkeK006903 for audit@freebsd.org; Fri, 4 Oct 2002 17:47:46 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Fri, 4 Oct 2002 17:47:45 +0300 From: Giorgos Keramidas To: audit@freebsd.org Subject: sys/alpha/alpha message diff Message-ID: <20021004144745.GA6809@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I noticed that the dec_*.c files in sys/alpha/alpha use a variety of styles in the messages they print before panic(). Does the following look reasonable to those of you who know more about Alphas than me? I haven't run it through a buildkernel on beast, but that's the next step if there are no loud arguments against the change. %%% Index: dec_1000a.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_1000a.c,v retrieving revision 1.13 diff -u -r1.13 dec_1000a.c --- dec_1000a.c 22 Aug 2002 19:52:15 -0000 1.13 +++ dec_1000a.c 4 Oct 2002 14:41:31 -0000 @@ -226,11 +226,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %d\n", - (int)ctb->ctb_term_type); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_2100_a50.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_2100_a50.c,v retrieving revision 1.13 diff -u -r1.13 dec_2100_a50.c --- dec_2100_a50.c 22 Aug 2002 19:52:15 -0000 1.13 +++ dec_2100_a50.c 4 Oct 2002 14:41:44 -0000 @@ -148,10 +148,7 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %ld\n", + panic("consinit: unknown console type %ld", ctb->ctb_term_type); } } Index: dec_2100_a500.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_2100_a500.c,v retrieving revision 1.12 diff -u -r1.12 dec_2100_a500.c --- dec_2100_a500.c 22 Aug 2002 19:52:15 -0000 1.12 +++ dec_2100_a500.c 4 Oct 2002 14:41:51 -0000 @@ -133,8 +133,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - panic("consinit: unknown console type"); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_axppci_33.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_axppci_33.c,v retrieving revision 1.16 diff -u -r1.16 dec_axppci_33.c --- dec_axppci_33.c 22 Aug 2002 19:52:15 -0000 1.16 +++ dec_axppci_33.c 4 Oct 2002 14:42:09 -0000 @@ -159,10 +159,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type"); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_eb164.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_eb164.c,v retrieving revision 1.16 diff -u -r1.16 dec_eb164.c --- dec_eb164.c 22 Aug 2002 19:52:16 -0000 1.16 +++ dec_eb164.c 4 Oct 2002 14:42:18 -0000 @@ -136,11 +136,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %d\n", - (int)ctb->ctb_term_type); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_eb64plus.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_eb64plus.c,v retrieving revision 1.12 diff -u -r1.12 dec_eb64plus.c --- dec_eb64plus.c 22 Aug 2002 19:52:16 -0000 1.12 +++ dec_eb64plus.c 4 Oct 2002 14:42:29 -0000 @@ -162,11 +162,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %d\n", - (int)ctb->ctb_term_type); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_kn20aa.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_kn20aa.c,v retrieving revision 1.14 diff -u -r1.14 dec_kn20aa.c --- dec_kn20aa.c 22 Aug 2002 19:52:16 -0000 1.14 +++ dec_kn20aa.c 4 Oct 2002 14:42:38 -0000 @@ -139,11 +139,8 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %d\n", - (int)ctb->ctb_term_type); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } #if 0 Index: dec_kn300.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_kn300.c,v retrieving revision 1.9 diff -u -r1.9 dec_kn300.c --- dec_kn300.c 22 Aug 2002 19:52:16 -0000 1.9 +++ dec_kn300.c 4 Oct 2002 14:44:46 -0000 @@ -134,8 +134,7 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - panic("consinit: unknown cons type %ld\n", ctb->ctb_term_type); + panic("consinit: unknown console type %ld", + ctb->ctb_term_type); } } Index: dec_st550.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_st550.c,v retrieving revision 1.12 diff -u -r1.12 dec_st550.c --- dec_st550.c 22 Aug 2002 19:52:16 -0000 1.12 +++ dec_st550.c 4 Oct 2002 14:45:16 -0000 @@ -136,10 +136,7 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %ld\n", + panic("consinit: unknown console type %ld", ctb->ctb_term_type); } } Index: dec_st6600.c =================================================================== RCS file: /home/ncvs/src/sys/alpha/alpha/dec_st6600.c,v retrieving revision 1.13 diff -u -r1.13 dec_st6600.c --- dec_st6600.c 22 Aug 2002 19:52:16 -0000 1.13 +++ dec_st6600.c 4 Oct 2002 14:45:39 -0000 @@ -121,10 +121,7 @@ break; default: - printf("ctb->ctb_term_type = 0x%lx\n", ctb->ctb_term_type); - printf("ctb->ctb_turboslot = 0x%lx\n", ctb->ctb_turboslot); - - panic("consinit: unknown console type %ld\n", + panic("consinit: unknown console type %ld", ctb->ctb_term_type); } } %%% To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message