From owner-freebsd-arch@FreeBSD.ORG Wed Dec 17 03:33:49 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 651B51065693 for ; Wed, 17 Dec 2008 03:33:49 +0000 (UTC) (envelope-from peter@wemm.org) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30]) by mx1.freebsd.org (Postfix) with ESMTP id 29A9E8FC21 for ; Wed, 17 Dec 2008 03:33:49 +0000 (UTC) (envelope-from peter@wemm.org) Received: by yw-out-2324.google.com with SMTP id 9so2166023ywe.13 for ; Tue, 16 Dec 2008 19:33:48 -0800 (PST) Received: by 10.100.143.12 with SMTP id q12mr157119and.22.1229484828183; Tue, 16 Dec 2008 19:33:48 -0800 (PST) Received: by 10.100.211.19 with HTTP; Tue, 16 Dec 2008 19:33:48 -0800 (PST) Message-ID: Date: Tue, 16 Dec 2008 19:33:48 -0800 From: "Peter Wemm" To: "M. Warner Losh" In-Reply-To: <20081216.131845.-1739986974.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081216.131845.-1739986974.imp@bsdimp.com> Cc: arch@freebsd.org Subject: Re: Removing some cruft... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2008 03:33:49 -0000 On Tue, Dec 16, 2008 at 12:18 PM, M. Warner Losh wrote: > I was looking at the MIPS elf stuff based on a submission of some > 64-bit support. In doing so, I discovered a number of 'unused' types > that appear to have comments that indicate that they can be removed > now and were just slavishly copied from arch to arch to arch. > > /* > * The following non-standard values are used for passing information > * from John Polstra's testbed program to the dynamic linker. These > * are expected to go away soon. > * > * Unfortunately, these overlap the Linux non-standard values, so they > * must not be used in the same context. > */ > #define AT_BRK 10 /* Starting point for sbrk and brk. */ > #define AT_DEBUG 11 /* Debugging level. */ > > These have be slavishly copied to arm, powerpc, sparc64, ia64, mips, > sun4v and amd64. All these files have nearly identical comments > (except powerpc, which changes the value). [..] > So I'd like to remove all this stuff unless there's a compelling > reason to keep it. > > Can anybody think of a reason to keep it? It seems completely > non-functional... Remove it completely. It probably should never have been committed to the tree in the first place. In either case, it has been OBE for a good ~10 years. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell