From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 21:32:31 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8C1AC126; Thu, 23 Jan 2014 21:32:31 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3F2A51E31; Thu, 23 Jan 2014 21:32:31 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id q10so2269845pdj.24 for ; Thu, 23 Jan 2014 13:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=u6d6ULHVpk8xtW+ulTWcyWRJx0IwMZtZJYztfD0wk8k=; b=HtXi/KqVB3G8us/Hwk3Qxk7flYoD5ciCssxKSjppNeIqcONeuXjaNhyAfyU82Y0PTE BSd9mcOiHcMMYAURXZ91rblJyTKj57mPYSYJmeyt0tuyjBWRE/LJKeFYfpPazF5r1D5J IIXM02Vnz82wM+XqEZlRUlAJXG1MW3WnC//hwhOgqiZJcAIVe2zRd9enaFCY4oOmchhj iAI4wB+i3H4LrSDaDMmjnwPs/fbdklY4uaWLAsqNO/1atknnlde03DV4ePG6IHeoyMh6 jyfBHaoVlyAFvebe35t1PV26da65k9W3VRK7pfK2G78n+AZxIj3hqE6+YI5mJN2UGzAN SD/w== X-Received: by 10.66.164.70 with SMTP id yo6mr10491990pab.85.1390512750933; Thu, 23 Jan 2014 13:32:30 -0800 (PST) Received: from fuji.zcorp.zonarsystems.com ([64.14.143.130]) by mx.google.com with ESMTPSA id nw11sm66148624pab.13.2014.01.23.13.32.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 13:32:30 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Makefile.inc1.patch From: Garrett Cooper In-Reply-To: Date: Thu, 23 Jan 2014 13:32:28 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> To: Alan Somers X-Mailer: Apple Mail (2.1827) Cc: "freebsd-testing@freebsd.org" , Brooks Davis , "Simon J. Gerraty" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 21:32:31 -0000 On Jan 23, 2014, at 1:29 PM, Alan Somers wrote: > On Thu, Jan 23, 2014 at 2:23 PM, Garrett Cooper = wrote: >> On Jan 23, 2014, at 1:11 PM, Alan Somers wrote: >>=20 >>> In that case, I'm missing something. I can't find any makefiles = that >>> reference MK_ATF or a related variable. What is the effect of = setting >>> WITH_ATF ? >>>=20 >>> -Alan >>=20 >> NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS = in the various build steps it will force ATF to not be built. For that = reason (and that reason alone) I reintroduced WITH_ATF just for = Makefile.inc1 (but you could replace it with something else like = WITH_ATF_LIBS, etc, if the naming is too confusing). >> Thanks! >> -Garrett >=20 > I get that much, but what I don't understand is what direct affect > WITH_ATF has. Did you forget to reintroduce a ".if defined(MK_ATF)" > in some other file? No, the purpose of WITH_ATF is to override NO_TESTS, so building the ATF = libs now has two conditions: build_atf_libs =3D (is WITH_ATF defined?) && (is WITHOUT_TESTS defined?) versus one: build_atf_libs =3D (is WITHOUT_TESTS defined?) This allows us pepper NO_TESTS around and thus not build tests in the = build process unless they=92re _really_ needed (e.g. in make = everything). Thanks! -Garrett=