From owner-freebsd-current@FreeBSD.ORG Fri Jul 30 04:01:41 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA4CA16A4CE for ; Fri, 30 Jul 2004 04:01:41 +0000 (GMT) Received: from mail.parodius.com (mail.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B24743D1F for ; Fri, 30 Jul 2004 04:01:41 +0000 (GMT) (envelope-from jdc@pentarou.parodius.com) Received: from pentarou.parodius.com (jdc@localhost [127.0.0.1]) by mail.parodius.com (8.12.11/8.12.11) with ESMTP id i6U41aDV008720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 29 Jul 2004 21:01:36 -0700 (PDT) (envelope-from jdc@pentarou.parodius.com) Received: (from jdc@localhost) by pentarou.parodius.com (8.12.11/8.12.11/Submit) id i6U41ZCH008719 for freebsd-current@freebsd.org; Thu, 29 Jul 2004 21:01:36 -0700 (PDT) (envelope-from jdc) Date: Thu, 29 Jul 2004 21:01:35 -0700 From: Jeremy Chadwick To: freebsd-current@freebsd.org Message-ID: <20040730040135.GA8297@parodius.com> Mail-Followup-To: freebsd-current@freebsd.org References: <20040729235949.GA2185@parodius.com> <20040730001444.GA2544@parodius.com> <20040730003949.GA17506@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040730003949.GA17506@freefall.freebsd.org> User-Agent: Mutt/1.5.6i Subject: Re: Latest CVS: disklabel broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2004 04:01:41 -0000 Alexander (and Scott too), Adding -fno-unit-at-a-time to CFLAGS for boot2's Makefile looks to have fixed the problem. Verified via the following method (just to be sure), right after updating to the latest CVS and applying Alexander's patch: # rm -fr /usr/obj/* # cd /usr/src/sys/boot # make clean # make # make install # disklabel -B ad0s1 After this, the machine with a broken bootstrap came up without a hitch; no panic. One thing to investigate, however: kan@ committed a change to src/sys/boot/i386/boot2/boot2.c a few hours ago. Can we confirm that -fno-unit-at-a-time is the correct fix for this, and not what was committed? Is there any other regions of present -CURRENT since the gcc 3.4 merge that might be suffering from a similar phenomenon? -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. | On Fri, Jul 30, 2004 at 12:39:49AM +0000, Alexander Kabaev wrote: > On Thu, Jul 29, 2004 at 05:14:44PM -0700, Jeremy Chadwick wrote: > > Minor typo/clarification: the transition problem lies between boot1 > > and boot2, it seems. > > > > On one of the machines (which uses boot1 across serial console), > > the system reports "Invalid partition" when trying to boot from -- > > and yes, this is not a typo -- 0:ad(0,`). Manually typing in the > > correct device (which is 0:ad(0,a)) causes the machine to spit out > > an exception error and reboot automatically. > > > > Just wanted to clarify on that point. > > > > GCC 3.4 seems to be very likely cause of this problem. I guess your only > option is to get boot2 file from a system which predates GCC 3.4 and > install in on broken boxes. > > I am trying to find the likely cause of this failure. The very first > idea I managed to think of is that your problem is yet another fallout > from new GCC unit-at-a-time optimisation mode. Could you please test > an attached patch and report results here? > > > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/sys/boot/i386/boot2/Makefile,v > retrieving revision 1.55 > diff -u -r1.55 Makefile > --- Makefile 17 Feb 2004 07:13:03 -0000 1.55 > +++ Makefile 30 Jul 2004 00:31:37 -0000 > @@ -22,6 +22,7 @@ > > CFLAGS= -Os \ > -fno-guess-branch-probability -fomit-frame-pointer\ > + -fno-unit-at-a-time \ > -mno-align-long-strings \ > -mrtd \ > -D${BOOT2_UFS} \ > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"