Date: Wed, 11 Dec 2019 12:43:49 +0000 From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 242521] security/nss: fix build on powerpc* Message-ID: <bug-242521-21738-WWQwrXHEAF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-242521-21738@https.bugs.freebsd.org/bugzilla/> References: <bug-242521-21738@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242521 --- Comment #5 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 209861 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D209861 patch > altivec-types.h:19:1: error: use of 'long long' in AltiVec types is inval= id without '-mvsx' Hmm, Clang 9.0.0 doesn't complain. Tested via -target powerpc64-unknown-freebsd13.0. Given=20 > +.if ${ARCH} =3D=3D powerpc64 > +CFLAGS+=3D -mvsx Adding -mvsx globally (for all files) would defeat runtime detection and ma= ke the binary package unusable without VSX support (assuming auto-vectorizatio= n). Can you try adding -mvsx after -maltivec? If it works submit the fix upstre= am. # To build via GYP use build.sh in root directory $ rg -- -maltivec lib/freebl/freebl.gyp 162: '-maltivec' 166: '-maltivec' lib/freebl/Makefile 793:$(OBJDIR)/$(PROG_PREFIX)gcm-ppc$(OBJ_SUFFIX): CFLAGS +=3D -mcrypto -mal= tivec > + sysctlbyname("hw.cpu_features", &hwcaps, &len, NULL, 0); hw.cpu_features (unlike hw.cpu_features2) will never return PPC_FEATURE2_*. Also, won't build on FreeBSD 11 due to incorrect includes. See upstream rev= iew comment. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242521-21738-WWQwrXHEAF>